RESOLVED FIXED 145546
Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console 
https://bugs.webkit.org/show_bug.cgi?id=145546
Summary Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in th...
Joseph Pecoraro
Reported 2015-06-01 21:16:27 PDT
* SUMMARY: In the Resources and Debugger tabs, ⌘F no longer brings up find-in-page bar once I start using the quick console. * STEPS TO REPRODUCE 1. Open a file in the Resources tab. 2. Press ⌘F and observe that a find-in-page bar appears. Click the Done button. 3. Select the quick console and type `window`. Observe that the window object is logged. 4. Return the cursor to the source code editor and press ⌘F again. => The find-in-page bar no longer appears.
Attachments
[PATCH] Proposed Fix (4.32 KB, patch)
2015-06-01 21:35 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (5.52 KB, patch)
2015-06-02 12:01 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-06-01 21:17:10 PDT
<rdar://problem/21189167>
Joseph Pecoraro
Comment 2 2015-06-01 21:35:01 PDT
Created attachment 254048 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2015-06-01 21:54:36 PDT
Comment on attachment 254048 [details] [PATCH] Proposed Fix We don't need to toggle disabled if they are scoped.
Joseph Pecoraro
Comment 4 2015-06-01 22:08:43 PDT
Comment on attachment 254048 [details] [PATCH] Proposed Fix Ahh, I agree. We should still enable/disable keyboard shortcuts for the findBanner, but we won't need to for the ContentBrowser. I'll update the patch once the other, conflicting part, lands.
Joseph Pecoraro
Comment 5 2015-06-02 12:01:52 PDT
Created attachment 254076 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 6 2015-06-02 13:01:05 PDT
The commit-queue encountered the following flaky tests while processing attachment 254076 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2015-06-02 13:01:43 PDT
The commit-queue encountered the following flaky tests while processing attachment 254076 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2015-06-02 14:14:49 PDT
Comment on attachment 254076 [details] [PATCH] For Landing Clearing flags on attachment: 254076 Committed r185121: <http://trac.webkit.org/changeset/185121>
Note You need to log in before you can comment on or make changes to this bug.