143732 – Correct layering violation in DumpRenderTree Build

RESOLVED FIXED 143732

Correct layering violation in DumpRenderTree Build

https://bugs.webkit.org/show_bug.cgi?id=143732

Summary Correct layering violation in DumpRenderTree Build

Brent Fulgham

Reported 2015-04-14 15:19:40 PDT

In Bug 143286, I introduced a layering violation between DumpRenderTree and WebCore. Instead of accessing WebCore types directly, DRT needs to pass through the WebCoreTestSupport library to manipulate WebCore state.

Attachments
Patch (5.73 KB, patch) 2015-04-14 16:02 PDT, Brent Fulgham	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2015-04-14 16:02:24 PDT

Created attachment 250750 [details] Patch

Brent Fulgham

Comment 2 2015-04-14 16:48:58 PDT

Committed r182821: <http://trac.webkit.org/changeset/182821>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component Tools / Tests

Assignee

Brent Fulgham

Reported

2015-04-14 15:19 PDT

Modified

2015-04-14 16:48 PDT History

CC List

2 users Show

URL

Keywords

Depends on

Blocks

143684

Dependencies

tree graph