141157 – Web platform test server should not try to launch servers on already bound sockets

RESOLVED FIXED 141157

Web platform test server should not try to launch servers on already bound sockets

https://bugs.webkit.org/show_bug.cgi?id=141157

Summary Web platform test server should not try to launch servers on already bound so...

youenn fablet

Reported 2015-02-02 06:02:57 PST

The current wpt server config.json mandates to use 8443 for https, which conflicts with Apache https server used for http/tests layout tests. A similar issue may arise for the websocket server. The config.json should be updated accordingly. Some WPT tests making use of https and websocket should be imported at the same time to ensure wpt https and ws servers work fine.

Attachments
Patch (4.23 KB, patch) 2015-02-23 08:57 PST, youenn fablet	no flags	Details Formatted Diff Diff
Rebasing (4.31 KB, patch) 2016-03-11 06:56 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (735.98 KB, application/zip) 2016-03-11 07:40 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (799.20 KB, application/zip) 2016-03-11 07:43 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (604.67 KB, application/zip) 2016-03-11 07:48 PST, Build Bot	no flags	Details
Rebasing test expectations (10.05 KB, patch) 2016-03-11 07:54 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (10.02 KB, patch) 2016-03-14 01:46 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-02 for mac-yosemite (812.74 KB, application/zip) 2016-03-14 03:06 PDT, WebKit Commit Bot	no flags	Details
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2015-02-23 08:57:43 PST

Created attachment 247121 [details] Patch

Brent Fulgham

Comment 2 2016-03-10 10:48:05 PST

Comment on attachment 247121 [details] Patch This change seems good to me. Could you please rebaseline and I'll approve it after a clean EWS run?

Brent Fulgham

Comment 3 2016-03-10 10:48:33 PST

(In reply to comment #2) > Comment on attachment 247121 [details] > Patch > > This change seems good to me. Could you please rebaseline and I'll approve > it after a clean EWS run? Actually, I'm trying it right now. If it works we can take it as-is.

Brent Fulgham

Comment 4 2016-03-10 10:51:05 PST

(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 247121 [details] > > Patch > > > > This change seems good to me. Could you please rebaseline and I'll approve > > it after a clean EWS run? > > Actually, I'm trying it right now. If it works we can take it as-is. Bummer. The patch is so old it won't apply. Could you please update it and I'll approve it?

Brent Fulgham

Comment 5 2016-03-10 10:51:46 PST

Comment on attachment 247121 [details] Patch Patch does not apply anymore :-(

youenn fablet

Comment 6 2016-03-10 11:59:15 PST

I'll rebase it.

youenn fablet

Comment 7 2016-03-11 06:56:45 PST

Created attachment 273724 [details] Rebasing

Build Bot

Comment 8 2016-03-11 07:40:32 PST

Comment on attachment 273724 [details] Rebasing Attachment 273724 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/960962 New failing tests: imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.html

Build Bot

Comment 9 2016-03-11 07:40:35 PST

Created attachment 273726 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2016-03-11 07:43:11 PST

Comment on attachment 273724 [details] Rebasing Attachment 273724 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/960966 New failing tests: imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.html

Build Bot

Comment 11 2016-03-11 07:43:14 PST

Created attachment 273727 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 12 2016-03-11 07:48:22 PST

Comment on attachment 273724 [details] Rebasing Attachment 273724 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/960969 New failing tests: imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.html

Build Bot

Comment 13 2016-03-11 07:48:25 PST

Created attachment 273729 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5

youenn fablet

Comment 14 2016-03-11 07:54:50 PST

Created attachment 273730 [details] Rebasing test expectations

WebKit Commit Bot

Comment 15 2016-03-14 01:28:33 PDT

Comment on attachment 273730 [details] Rebasing test expectations Rejecting attachment 273730 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 273730, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ted/w3c/ChangeLog fatal: multiple stage entries for merged file 'LayoutTests/imported/w3c' Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 128 cwd: /Volumes/Data/EWS/WebKit You have both LayoutTests/imported/w3c and LayoutTests/imported/w3c/ChangeLog fatal: multiple stage entries for merged file 'LayoutTests/imported/w3c' Failed to run "['git', 'commit', '--all', '-F', '-']" exit_code: 128 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/976002

youenn fablet

Comment 16 2016-03-14 01:46:22 PDT

Created attachment 273941 [details] Patch for landing

WebKit Commit Bot

Comment 17 2016-03-14 03:06:27 PDT

Comment on attachment 273941 [details] Patch for landing Rejecting attachment 273941 [details] from commit-queue. New failing tests: transitions/default-timing-function.html Full output: http://webkit-queues.webkit.org/results/976282

WebKit Commit Bot

Comment 18 2016-03-14 03:06:31 PDT

Created attachment 273948 [details] Archive of layout-test-results from webkit-cq-02 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-yosemite Platform: Mac OS X 10.10.5

WebKit Commit Bot

Comment 19 2016-03-14 04:24:54 PDT

The commit-queue encountered the following flaky tests while processing attachment 273941 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 20 2016-03-14 04:25:28 PDT

The commit-queue encountered the following flaky tests while processing attachment 273941 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 21 2016-03-14 05:10:10 PDT

Comment on attachment 273941 [details] Patch for landing Clearing flags on attachment: 273941 Committed r198116: <http://trac.webkit.org/changeset/198116>

WebKit Commit Bot

Comment 22 2016-03-14 05:10:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

youenn fablet

Reported

2015-02-02 06:02 PST

Modified

2016-03-14 05:10 PDT History

CC List

7 users Show

URL

Keywords

Depends on

Blocks