WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED LATER
140374
Web Replay: animations should pause when deterministic playback is paused
https://bugs.webkit.org/show_bug.cgi?id=140374
Summary
Web Replay: animations should pause when deterministic playback is paused
Brian Burg
Reported
2015-01-12 15:20:08 PST
It would be nice to suspend animations while a playback is paused, using the same code path as suspending when changing tabs or for a modal dialog. Some issues with this: the code to suspend (Document::suspend+resumeScheduledTasks / PageGroupLoadDeferrer) will trigger timers which are normally deterministic such as ScriptRunner::m_timer and animation timers, which would cause a divergence by over-scheduling the timer. If playback is paused and we call suspendScheduledTasks, it calls ScriptRunner's m_timer.stop(). A subsequent resumeScheduledTasks will do m_timer.startOneShot(0, this). I *think* that this second startOneShot should be ignored, as it could run JS prematurely if some scripts were pending when playback pauses.
Attachments
Add attachment
proposed patch, testcase, etc.
Blaze Burg
Comment 1
2017-07-10 13:59:33 PDT
Closing web replay-related bugs until we resume working on the feature again.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug