136044 – [CSS Font Loading] Enable Page Caching

RESOLVED FIXED 136044

[CSS Font Loading] Enable Page Caching

https://bugs.webkit.org/show_bug.cgi?id=136044

Summary [CSS Font Loading] Enable Page Caching

Bear Travis

Reported 2014-08-18 11:32:37 PDT

The Font Loader API disables page caching. As a first approximation, enable page caching when no font rules are currently loading, and the load() method has not been called.

Attachments
Patch Prototype (13.95 KB, patch) 2014-08-19 11:35 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Updated Prototype (16.12 KB, patch) 2014-08-25 17:09 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (482.05 KB, application/zip) 2014-08-25 18:43 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (502.92 KB, application/zip) 2014-08-25 19:25 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (498.20 KB, application/zip) 2014-08-25 20:20 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (498.99 KB, application/zip) 2014-08-25 21:22 PDT, Build Bot	no flags	Details
Updated Prototype (16.12 KB, patch) 2014-08-26 10:17 PDT, Bear Travis	no flags	Details Formatted Diff Diff
First Draft (10.77 KB, patch) 2014-08-27 12:32 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (552.13 KB, application/zip) 2014-08-27 13:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (534.12 KB, application/zip) 2014-08-27 17:48 PDT, Build Bot	no flags	Details
Skipping test (12.41 KB, patch) 2014-08-28 14:33 PDT, Bear Travis	kling: review+	Details Formatted Diff Diff
Incorporating feedback (12.04 KB, patch) 2014-09-02 15:22 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Bear Travis

Comment 1 2014-08-19 11:35:24 PDT

Created attachment 236818 [details] Patch Prototype

Bear Travis

Comment 2 2014-08-25 17:09:56 PDT

Created attachment 237119 [details] Updated Prototype Updating the prototype. Feature is still toggled on for the bots, so this is not quite ready for review.

Build Bot

Comment 3 2014-08-25 18:43:42 PDT

Comment on attachment 237119 [details] Updated Prototype Attachment 237119 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6648736453230592 New failing tests: fast/css/fontloader-page-cache.html

Build Bot

Comment 4 2014-08-25 18:43:44 PDT

Created attachment 237123 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-08-25 19:25:47 PDT

Comment on attachment 237119 [details] Updated Prototype Attachment 237119 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4796164855562240 New failing tests: fast/css/fontloader-page-cache.html

Build Bot

Comment 6 2014-08-25 19:25:51 PDT

Created attachment 237127 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-08-25 20:20:29 PDT

Comment on attachment 237119 [details] Updated Prototype Attachment 237119 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6023479409246208 New failing tests: fast/css/fontloader-page-cache.html

Build Bot

Comment 8 2014-08-25 20:20:33 PDT

Created attachment 237128 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2014-08-25 21:22:05 PDT

Comment on attachment 237119 [details] Updated Prototype Attachment 237119 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5593205290565632 New failing tests: fast/css/fontloader-page-cache.html

Build Bot

Comment 10 2014-08-25 21:22:08 PDT

Created attachment 237134 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Bear Travis

Comment 11 2014-08-26 10:17:09 PDT

Created attachment 237155 [details] Updated Prototype

Bear Travis

Comment 12 2014-08-27 12:32:23 PDT

Created attachment 237237 [details] First Draft Removing feature enablement. This patch should be ready for review, but will not have the feature enabled yet.

Build Bot

Comment 13 2014-08-27 13:05:02 PDT

Comment on attachment 237237 [details] First Draft Attachment 237237 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4723508772864000 New failing tests: fast/css/fontloader-page-cache.html

Build Bot

Comment 14 2014-08-27 13:05:06 PDT

Created attachment 237241 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 15 2014-08-27 17:48:12 PDT

Comment on attachment 237237 [details] First Draft Attachment 237237 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4684673678573568 New failing tests: fast/css/fontloader-page-cache.html

Build Bot

Comment 16 2014-08-27 17:48:16 PDT

Created attachment 237276 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Bear Travis

Comment 17 2014-08-28 14:33:04 PDT

Created attachment 237326 [details] Skipping test Added test must be skipped until feature is enabled

Andreas Kling

Comment 18 2014-09-02 11:33:44 PDT

Comment on attachment 237326 [details] Skipping test View in context: https://bugs.webkit.org/attachment.cgi?id=237326&action=review r=me as the logic appears sound. > Source/WebCore/css/FontLoader.cpp:72 > + int familyCount() const { return m_numFamilies; } I'd call it m_familyCount for consistency. > Source/WebCore/css/FontLoader.h:104 > + unsigned m_rulesLoading; > + unsigned m_stringsLoading; Can we come up with some better names for these? m_stringsLoading is especially unobvious.

Bear Travis

Comment 19 2014-09-02 15:22:27 PDT

Created attachment 237518 [details] Incorporating feedback Incorporating feedback from kling. Renaming counts to m_numLoadingFromCSS and m_numLoadingFromJS.

WebKit Commit Bot

Comment 20 2014-09-03 10:26:25 PDT

Comment on attachment 237518 [details] Incorporating feedback Clearing flags on attachment: 237518 Committed r173209: <http://trac.webkit.org/changeset/173209>

WebKit Commit Bot

Comment 21 2014-09-03 10:26:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component CSS

Assignee

Bear Travis

Reported

2014-08-18 11:32 PDT

Modified

2014-09-03 10:26 PDT History

CC List

6 users Show

URL

Keywords

Depends on

Blocks

135390

Dependencies

tree graph