RESOLVED FIXED 135803
Web Inspector: use type builders to construct high fidelity type information payloads 
https://bugs.webkit.org/show_bug.cgi?id=135803
Summary Web Inspector: use type builders to construct high fidelity type information ...
Brian Burg
Reported 2014-08-11 09:40:34 PDT
Due to a typo in Runtime.json, it seems that all of the payload construction code works with raw unchecked objects. We should use type builders.
Attachments
Patch (18.56 KB, patch)
2014-08-11 10:41 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-11 09:40:46 PDT
<rdar://problem/17977654>
Brian Burg
Comment 2 2014-08-11 10:41:08 PDT
Created attachment 236379 [details] Patch
WebKit Commit Bot
Comment 3 2014-08-11 10:43:01 PDT
Attachment 236379 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/HighFidelityTypeProfiler.h:99: The parameter name "descriptor" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4 2014-08-11 12:20:05 PDT
Comment on attachment 236379 [details] Patch Clearing flags on attachment: 236379 Committed r172402: <http://trac.webkit.org/changeset/172402>
WebKit Commit Bot
Comment 5 2014-08-11 12:20:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.