RESOLVED FIXED 135170
Web Inspector: show a replay dashboard when capturing or replaying 
https://bugs.webkit.org/show_bug.cgi?id=135170
Summary Web Inspector: show a replay dashboard when capturing or replaying
Brian Burg
Reported 2014-07-22 13:14:32 PDT
Since replay is a system-wide property, the user should be able to see the system's replay status when it is relevant to the inspected web content. For example, the replay dashboard should be automatically shown when capturing or replaying starts.
Attachments
Patch (21.11 KB, patch)
2014-08-05 12:24 PDT, Brian Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-22 13:15:05 PDT
<rdar://problem/17767423>
Brian Burg
Comment 2 2014-07-22 16:02:54 PDT
Eventually I want to get some sort of mini-timeline ported to the new replay infrastructure (the one in trunk). There is also some more plumbing needed in the replay protocol domain so that recordings can be ejected and imported/exported from file. My current WIP patch adds record/play/pause buttons that are correctly synced to events from the WebInspector.ReplayManager. Since this UI isn't visible by default, I could submit just this functionality and incrementally add the other pieces. In any case, the UI will not be terribly useful until major replay blockers are landed in the next few months. Landing incrementally just reduces bitrot and branch drift.
Timothy Hatcher
Comment 3 2014-08-05 11:40:29 PDT
Missing patch? Looks like bug 135225 builds on this.
Brian Burg
Comment 4 2014-08-05 12:24:22 PDT
Created attachment 236043 [details] Patch
Timothy Hatcher
Comment 5 2014-08-11 07:48:19 PDT
Comment on attachment 236043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236043&action=review > Source/WebInspectorUI/ChangeLog:20 > + * UserInterface/Images/ReplayPauseButton.svg: Added. > + * UserInterface/Images/ReplayPlayButton.svg: Added. > + * UserInterface/Images/ReplayRecordingButton.svg: Added. Once this lands I will take a look at making new icons for these to match 10.10. > Source/WebInspectorUI/UserInterface/Views/ReplayDashboardView.js:62 > + if (WebInspector.replayManager.sessionState === WebInspector.ReplayManager.SessionState.Capturing) > + this._captureStarted(); > + else if (WebInspector.replayManager.sessionState === WebInspector.ReplayManager.SessionState.Inactive) > + this._captureStopped(); > + // ReplayManager.sessionState must be Replaying. > + else if (WebInspector.replayManager.segmentState === WebInspector.ReplayManager.SegmentState.Dispatching) > + this._playbackStarted(); > + // ReplayManager.sessionState must be Unloaded or Loaded, so execution is paused. > + else > + this._playbackPaused(); switch?
Brian Burg
Comment 6 2014-08-11 16:41:48 PDT
Committed r172420: <http://trac.webkit.org/changeset/172420>
Note You need to log in before you can comment on or make changes to this bug.