127257 – Implement ANGLE_instanced_arrays

RESOLVED FIXED 127257

Implement ANGLE_instanced_arrays

https://bugs.webkit.org/show_bug.cgi?id=127257

Summary Implement ANGLE_instanced_arrays

Dean Jackson

Reported 2014-01-19 13:12:34 PST

Implement instanced drawing extension.

Attachments
Patch (52.74 KB, patch) 2014-01-19 13:19 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (452.32 KB, application/zip) 2014-01-19 16:29 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (490.99 KB, application/zip) 2014-01-19 16:58 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (595.27 KB, application/zip) 2014-01-19 17:16 PST, Build Bot	no flags	Details
Patch (52.47 KB, patch) 2014-01-20 11:33 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (458.69 KB, application/zip) 2014-01-20 12:20 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (489.15 KB, application/zip) 2014-01-20 12:51 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (487.84 KB, application/zip) 2014-01-20 13:50 PST, Build Bot	no flags	Details
Patch (85.78 KB, patch) 2014-01-20 14:00 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (465.66 KB, application/zip) 2014-01-20 14:59 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (491.91 KB, application/zip) 2014-01-20 15:23 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (495.56 KB, application/zip) 2014-01-20 16:27 PST, Build Bot	no flags	Details
Patch (87.17 KB, patch) 2014-01-22 13:32 PST, Dean Jackson	bfulgham: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (462.82 KB, application/zip) 2014-01-22 14:26 PST, Build Bot	no flags	Details
Patch (88.45 KB, patch) 2014-01-22 14:48 PST, Dean Jackson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (497.80 KB, application/zip) 2014-01-22 15:00 PST, Build Bot	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-01-19 13:14:19 PST

<rdar://problem/15855212>

Dean Jackson

Comment 2 2014-01-19 13:19:03 PST

Created attachment 221596 [details] Patch

Dean Jackson

Comment 3 2014-01-19 13:19:41 PST

Upload a patch to test build.

Dean Jackson

Comment 4 2014-01-19 13:20:25 PST

The patch isn't quite ready. It's mostly about understanding what other ports will do when they see the new gl functions. I expect they'll fail to compile.

WebKit Commit Bot

Comment 5 2014-01-19 15:40:47 PST

Attachment 221596 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1633: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1636: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1639: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1642: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1646: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1649: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2029: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/CMakeLists.txt:2668: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] Total errors found: 11 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 6 2014-01-19 16:29:10 PST

Comment on attachment 221596 [details] Patch Attachment 221596 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5723923182256128 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Build Bot

Comment 7 2014-01-19 16:29:13 PST

Created attachment 221599 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 8 2014-01-19 16:58:52 PST

Comment on attachment 221596 [details] Patch Attachment 221596 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5213381493522432 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Build Bot

Comment 9 2014-01-19 16:58:55 PST

Created attachment 221601 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 10 2014-01-19 17:16:29 PST

Comment on attachment 221596 [details] Patch Attachment 221596 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5117696265945088 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Build Bot

Comment 11 2014-01-19 17:16:33 PST

Created attachment 221603 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Dean Jackson

Comment 12 2014-01-20 11:33:38 PST

Created attachment 221677 [details] Patch

WebKit Commit Bot

Comment 13 2014-01-20 11:35:21 PST

Attachment 221677 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/CMakeLists.txt:2668: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] Total errors found: 4 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 14 2014-01-20 12:20:28 PST

Comment on attachment 221677 [details] Patch Attachment 221677 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5956872209170432 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Build Bot

Comment 15 2014-01-20 12:20:31 PST

Created attachment 221681 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 16 2014-01-20 12:51:55 PST

Comment on attachment 221677 [details] Patch Attachment 221677 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5771939842883584 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Build Bot

Comment 17 2014-01-20 12:51:59 PST

Created attachment 221683 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 18 2014-01-20 13:50:10 PST

Comment on attachment 221677 [details] Patch Attachment 221677 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6286037227667456 New failing tests: fast/canvas/webgl/oes-texture-half-float.html

Build Bot

Comment 19 2014-01-20 13:50:14 PST

Created attachment 221689 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Dean Jackson

Comment 20 2014-01-20 14:00:20 PST

Created attachment 221691 [details] Patch

WebKit Commit Bot

Comment 21 2014-01-20 14:03:02 PST

Attachment 221691 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:2669: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 22 2014-01-20 14:17:59 PST

Comment on attachment 221691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221691&action=review Looks good to me, modulo the efl build error. r=me > Source/WebCore/DerivedSources.cpp:30 > +#include "JSANGLEInstancedArrays.cpp" Should this be protected by #if ENABLE(WEBGL)?

Build Bot

Comment 23 2014-01-20 14:59:22 PST

Comment on attachment 221691 [details] Patch Attachment 221691 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4620986318061568 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Build Bot

Comment 24 2014-01-20 14:59:26 PST

Created attachment 221694 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 25 2014-01-20 15:23:20 PST

Comment on attachment 221691 [details] Patch Attachment 221691 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6439109862096896 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Build Bot

Comment 26 2014-01-20 15:23:25 PST

Created attachment 221698 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 27 2014-01-20 16:27:46 PST

Comment on attachment 221691 [details] Patch Attachment 221691 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6146376366817280 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Build Bot

Comment 28 2014-01-20 16:27:50 PST

Created attachment 221703 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Dean Jackson

Comment 29 2014-01-22 13:32:17 PST

Created attachment 221899 [details] Patch

Dean Jackson

Comment 30 2014-01-22 13:33:31 PST

Incorporated Brent's review comment. Trying to see if I can get it to compile before landing. Not sure why the new test failed on mac :(

WebKit Commit Bot

Comment 31 2014-01-22 13:34:51 PST

Attachment 221899 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:2669: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 7 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 32 2014-01-22 14:26:46 PST

Comment on attachment 221899 [details] Patch Attachment 221899 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5804113644224512 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Build Bot

Comment 33 2014-01-22 14:26:49 PST

Created attachment 221904 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Dean Jackson

Comment 34 2014-01-22 14:48:04 PST

Created attachment 221907 [details] Patch

Dean Jackson

Comment 35 2014-01-22 14:49:31 PST

I think I worked it out. Mountain Lion needs specific results. No need for review.

WebKit Commit Bot

Comment 36 2014-01-22 14:50:36 PST

Attachment 221907 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:2669: Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp". [list/order] [5] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 7 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 37 2014-01-22 15:00:34 PST

Comment on attachment 221899 [details] Patch Attachment 221899 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6093500286238720 New failing tests: fast/canvas/webgl/angle-instanced-arrays.html

Build Bot

Comment 38 2014-01-22 15:00:42 PST

Created attachment 221910 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Dean Jackson

Comment 39 2014-01-22 15:45:14 PST

Committed r162565: <http://trac.webkit.org/changeset/162565>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebGL

Assignee

Dean Jackson

Reported

2014-01-19 13:12 PST

Modified

2014-01-22 15:45 PST History

CC List

13 users Show

URL

Keywords InRadar

Depends on

Blocks

126939

Dependencies

tree graph