WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
124827
Implement asymmetric/symmetric stretching of vertical operators
https://bugs.webkit.org/show_bug.cgi?id=124827
Summary
Implement asymmetric/symmetric stretching of vertical operators
Frédéric Wang (:fredw)
Reported
2013-11-25 01:22:36 PST
From the spec: "The symmetric attribute governs whether the height and depth above and below the axis of the character are forced to be equal (by forcing both height and depth to become the maximum of the two). An example of a situation where one might set symmetric="false" arises with parentheses around a matrix not aligned on the axis, which frequently occurs when multiplying non-square matrices. In this case, one wants the parentheses to stretch to cover the matrix, whereas stretching the parentheses symmetrically would cause them to protrude beyond one edge of the matrix. The symmetric attribute only applies to characters that stretch vertically (otherwise it is ignored). "
Attachments
Patch
(8.35 KB, patch)
2014-02-20 01:46 PST
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Patch + 119043 for testing
(42.83 KB, patch)
2014-02-20 01:51 PST
,
Frédéric Wang (:fredw)
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
(508.45 KB, application/zip)
2014-02-20 03:05 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
(536.11 KB, application/zip)
2014-02-20 03:29 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
(549.97 KB, application/zip)
2014-02-20 03:32 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
(532.22 KB, application/zip)
2014-02-20 04:23 PST
,
Build Bot
no flags
Details
Patch
(9.64 KB, patch)
2014-02-21 04:47 PST
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
Patch + 119043 for testing
(45.17 KB, patch)
2014-02-21 04:49 PST
,
Frédéric Wang (:fredw)
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
(503.28 KB, application/zip)
2014-02-21 06:01 PST
,
Build Bot
no flags
Details
Patch
(24.98 KB, patch)
2014-02-21 06:13 PST
,
Frédéric Wang (:fredw)
cfleizach
: review+
Details
Formatted Diff
Diff
Show Obsolete
(9)
View All
Add attachment
proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1
2014-02-20 01:46:45 PST
Created
attachment 224731
[details]
Patch Here is a very simple patch that applies on top of the one of
bug 119043
.
Frédéric Wang (:fredw)
Comment 2
2014-02-20 01:51:42 PST
Created
attachment 224732
[details]
Patch + 119043 for testing
Build Bot
Comment 3
2014-02-20 03:05:53 PST
Comment on
attachment 224732
[details]
Patch + 119043 for testing
Attachment 224732
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/6603106544517120
New failing tests: mathml/presentation/mo-stretch.html
Build Bot
Comment 4
2014-02-20 03:05:55 PST
Created
attachment 224739
[details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 5
2014-02-20 03:29:12 PST
Comment on
attachment 224732
[details]
Patch + 119043 for testing
Attachment 224732
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/4611460684578816
New failing tests: mathml/presentation/mo-stretch.html
Build Bot
Comment 6
2014-02-20 03:29:15 PST
Created
attachment 224740
[details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 7
2014-02-20 03:31:57 PST
Comment on
attachment 224732
[details]
Patch + 119043 for testing
Attachment 224732
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/5664742089687040
New failing tests: mathml/presentation/mo-stretch.html
Build Bot
Comment 8
2014-02-20 03:32:00 PST
Created
attachment 224741
[details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 9
2014-02-20 04:23:15 PST
Comment on
attachment 224732
[details]
Patch + 119043 for testing
Attachment 224732
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/6206439739621376
New failing tests: mathml/presentation/mo-stretch.html
Build Bot
Comment 10
2014-02-20 04:23:18 PST
Created
attachment 224746
[details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Frédéric Wang (:fredw)
Comment 11
2014-02-21 04:47:52 PST
Created
attachment 224850
[details]
Patch
Frédéric Wang (:fredw)
Comment 12
2014-02-21 04:49:05 PST
Created
attachment 224851
[details]
Patch + 119043 for testing
Build Bot
Comment 13
2014-02-21 06:01:29 PST
Comment on
attachment 224851
[details]
Patch + 119043 for testing
Attachment 224851
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/5191576280104960
New failing tests: mathml/presentation/mo-stretch.html
Build Bot
Comment 14
2014-02-21 06:01:31 PST
Created
attachment 224858
[details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Frédéric Wang (:fredw)
Comment 15
2014-02-21 06:13:41 PST
Created
attachment 224859
[details]
Patch Rebase mo-stretch to take into account the symmetric property. I'm asking review but the tests will fail because this depends on
bug 119043
.
chris fleizach
Comment 16
2014-02-21 23:22:12 PST
Comment on
attachment 224859
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=224859&action=review
> LayoutTests/mathml/presentation/stretchy-depth-height-symmetric.html:11 > + return Math.abs(x - y) < epsilon;
indendation levels should be +4 spaces
> Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:1266 > + // FIXME: We should read the read the axis from the MATH table (
https://bugs.webkit.org/show_bug.cgi?id=122297
). For now, we use the same value as in RenderMathMLFraction::firstLineBaseline().
too many words ---"should read the read the"
Frédéric Wang (:fredw)
Comment 17
2014-02-22 02:09:29 PST
Committed
r164537
: <
http://trac.webkit.org/changeset/164537
>
Frédéric Wang (:fredw)
Comment 18
2014-03-10 12:26:22 PDT
Mass change: add WebExposed keyword to help MDN documentation.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug