RESOLVED FIXED 124365
REGRESSION(r159276): Lots of crashes for ARM builds 
https://bugs.webkit.org/show_bug.cgi?id=124365
Summary REGRESSION(r159276): Lots of crashes for ARM builds
Julien Brianceau
Reported 2013-11-14 09:19:16 PST
Lots of crashes appeared for arm_traditional architecture since http://trac.webkit.org/changeset/159276 The issue is identified and I'll submit a patch soon
Attachments
Rearrange ARM_EXTRA_GPRS in LLINT and fix cCallX macros. (4.49 KB, patch)
2013-11-14 09:28 PST, Julien Brianceau 		msaboff: review-
msaboff: commit-queue-
DetailsFormatted DiffDiff
Updated the prior patch (3.77 KB, patch)
2013-11-14 11:34 PST, Michael Saboff 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-11-14 09:28:46 PST
Created attachment 216950 [details] Rearrange ARM_EXTRA_GPRS in LLINT and fix cCallX macros.
Michael Saboff
Comment 2 2013-11-14 11:06:39 PST
Comment on attachment 216950 [details] Rearrange ARM_EXTRA_GPRS in LLINT and fix cCallX macros. View in context: https://bugs.webkit.org/attachment.cgi?id=216950&action=review > Source/JavaScriptCore/offlineasm/arm.rb:465 > + $asm.puts "pop {r4-r6, r8-r12}" Since r12 is a global scratch, why do we need to save it? > Source/JavaScriptCore/offlineasm/arm.rb:471 > + $asm.puts "push {r4-r6, r8-r12}" Ditto.
Michael Saboff
Comment 3 2013-11-14 11:34:27 PST
Created attachment 216964 [details] Updated the prior patch
Michael Saboff
Comment 4 2013-11-14 11:41:02 PST
Committed r159298: <http://trac.webkit.org/changeset/159298>
Filip Pizlo
Comment 5 2013-11-14 11:47:31 PST
Comment on attachment 216964 [details] Updated the prior patch r=me too
Julien Brianceau
Comment 6 2013-11-14 15:22:13 PST
(In reply to comment #2) > > Source/JavaScriptCore/offlineasm/arm.rb:465 > > + $asm.puts "pop {r4-r6, r8-r12}" > > Since r12 is a global scratch, why do we need to save it? > > > Source/JavaScriptCore/offlineasm/arm.rb:471 > > + $asm.puts "push {r4-r6, r8-r12}" > > Ditto. You're right, that was not necessary. Thanks for the review & having landed it!
Note You need to log in before you can comment on or make changes to this bug.