RESOLVED FIXED 123462
Beef up CryptoKey 
https://bugs.webkit.org/show_bug.cgi?id=123462
Summary Beef up CryptoKey
Alexey Proskuryakov
Reported 2013-10-29 13:37:24 PDT
A bit of glue code to add here...
Attachments
proposed patch (26.85 KB, patch)
2013-10-29 13:47 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
with appropriate style fixes (24.81 KB, patch)
2013-10-29 13:52 PDT, Alexey Proskuryakov 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-29 13:47:19 PDT
Created attachment 215417 [details] proposed patch
WebKit Commit Bot
Comment 2 2013-10-29 13:50:08 PDT
Attachment 215417 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/crypto/CryptoAlgorithmIdentifier.h', u'Source/WebCore/crypto/CryptoKey.cpp', u'Source/WebCore/crypto/CryptoKey.h', u'Source/WebCore/crypto/CryptoKey.idl', u'Source/WebCore/crypto/CryptoKeyFormat.h', u'Source/WebCore/crypto/CryptoKeyType.h', u'Source/WebCore/crypto/CryptoKeyUsage.h']" exit_code: 1 Source/WebCore/crypto/CryptoKey.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/crypto/CryptoKeyFormat.h:33: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/crypto/CryptoKeyUsage.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/crypto/CryptoKeyUsage.h:35: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/crypto/CryptoKeyUsage.h:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/crypto/CryptoKeyUsage.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/crypto/CryptoKeyUsage.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/crypto/CryptoKeyUsage.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/crypto/CryptoKeyUsage.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/crypto/CryptoKeyUsage.h:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/crypto/CryptoKeyType.h:33: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:33: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 12 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2013-10-29 13:52:23 PDT
Created attachment 215420 [details] with appropriate style fixes Also, don't add JSDOMPromise to project yet, it's not in this patch.
WebKit Commit Bot
Comment 4 2013-10-29 13:53:26 PDT
Attachment 215420 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/crypto/CryptoAlgorithmIdentifier.h', u'Source/WebCore/crypto/CryptoKey.cpp', u'Source/WebCore/crypto/CryptoKey.h', u'Source/WebCore/crypto/CryptoKey.idl', u'Source/WebCore/crypto/CryptoKeyFormat.h', u'Source/WebCore/crypto/CryptoKeyType.h', u'Source/WebCore/crypto/CryptoKeyUsage.h']" exit_code: 1 Source/WebCore/crypto/CryptoKey.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/crypto/CryptoKeyFormat.h:33: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/crypto/CryptoKeyType.h:33: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/crypto/CryptoAlgorithmIdentifier.h:33: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 5 2013-10-29 16:11:22 PDT
Committed <http://trac.webkit.org/r158236>.
Alexey Proskuryakov
Comment 6 2013-10-29 16:31:39 PDT
And a build fix in <http://trac.webkit.org/r158239>
Note You need to log in before you can comment on or make changes to this bug.