RESOLVED FIXED 122837
[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837
Summary [MathML] Poor spacing around delimiters in MathML Torture Test 14
Martin Robinson
Reported 2013-10-15 09:24:18 PDT
In the attached test case and number 14 on the MathML torture test, the delimiters have too much spacing around them.
Attachments
Patch (92.02 KB, patch)
2013-10-31 15:43 PDT, Martin Robinson
no flags
Adjust the test to use ‖ instead of &DoubleVerticalLine; (92.81 KB, patch)
2013-10-31 16:10 PDT, Martin Robinson
no flags
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (518.57 KB, application/zip)
2013-10-31 17:02 PDT, Build Bot
no flags
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (787.14 KB, application/zip)
2013-10-31 19:01 PDT, Build Bot
no flags
Patch with Mac results from archive (186.08 KB, patch)
2013-11-04 10:46 PST, Martin Robinson
no flags
Uploading patch again to get new Mac results (32.57 KB, patch)
2013-11-09 18:02 PST, Martin Robinson
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (480.18 KB, application/zip)
2013-11-09 19:10 PST, Build Bot
no flags
Frédéric Wang (:fredw)
Comment 1 2013-10-15 09:57:46 PDT
Adding bug 99620, since having proper operator spacing will help here. I suspect we will end up doing something similar as Gecko to get accurate ink/logical metrics and do width correction.
Martin Robinson
Comment 2 2013-10-30 16:12:10 PDT
It looks like the issue here is very specific to the delimiter. In STIX, the stretchable delimiter is thicker with a very large left and right bearing. For us, this means that when we consider the stretchable delimiter as a possibility for drawing an operator we will always create a large amount of horizontal space for that operator. I think the fix here is to copy Gecko and ignore the stretchable delimiter.
Martin Robinson
Comment 3 2013-10-31 15:43:35 PDT
Martin Robinson
Comment 4 2013-10-31 16:10:00 PDT
Created attachment 215688 [details] Adjust the test to use ‖ instead of &DoubleVerticalLine;
Martin Robinson
Comment 5 2013-10-31 16:35:34 PDT
Bug 123543 also changes the mo-stretch test so it might makes sense to create Mac baselines when both these patches have landed.
Build Bot
Comment 6 2013-10-31 17:02:04 PDT
Comment on attachment 215688 [details] Adjust the test to use ‖ instead of &DoubleVerticalLine; Attachment 215688 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/19298017 New failing tests: mathml/presentation/mo-stretch.html
Build Bot
Comment 7 2013-10-31 17:02:06 PDT
Created attachment 215693 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2013-10-31 19:01:35 PDT
Comment on attachment 215688 [details] Adjust the test to use ‖ instead of &DoubleVerticalLine; Attachment 215688 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/19358066 New failing tests: mathml/presentation/mo-stretch.html
Build Bot
Comment 9 2013-10-31 19:01:37 PDT
Created attachment 215711 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Martin Robinson
Comment 10 2013-11-01 09:47:16 PDT
Tests fail for Mac because they need a rebaseline.
chris fleizach
Comment 11 2013-11-04 09:48:49 PST
Martin can you grab the results from the layout-test-results in the attached archives and update your patch again?
Martin Robinson
Comment 12 2013-11-04 10:46:15 PST
Created attachment 215930 [details] Patch with Mac results from archive
Martin Robinson
Comment 13 2013-11-04 12:42:27 PST
Looks like tests are passing now. :)
Brent Fulgham
Comment 14 2013-11-05 09:43:22 PST
Comment on attachment 215930 [details] Patch with Mac results from archive r=me
Radar WebKit Bug Importer
Comment 15 2013-11-05 09:46:34 PST
Martin Robinson
Comment 16 2013-11-05 10:04:13 PST
WebKit Commit Bot
Comment 17 2013-11-05 13:11:13 PST
Re-opened since this is blocked by bug 123820
Martin Robinson
Comment 18 2013-11-09 18:02:46 PST
Created attachment 216503 [details] Uploading patch again to get new Mac results
Build Bot
Comment 19 2013-11-09 19:10:09 PST
Comment on attachment 216503 [details] Uploading patch again to get new Mac results Attachment 216503 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22638963 New failing tests: mathml/presentation/mo-stretch.html
Build Bot
Comment 20 2013-11-09 19:10:14 PST
Created attachment 216504 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Martin Robinson
Comment 21 2013-11-09 19:37:49 PST
Note You need to log in before you can comment on or make changes to this bug.