WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
119809
[CSS Shapes] Add support for shape-outside image values
https://bugs.webkit.org/show_bug.cgi?id=119809
Summary
[CSS Shapes] Add support for shape-outside image values
Hans Muller
Reported
2013-08-14 11:49:01 PDT
See
http://dev.w3.org/csswg/css-shapes/#shapes-from-image
Attachments
Patch
(11.36 KB, patch)
2013-08-14 17:40 PDT
,
Hans Muller
achicu
: review+
Details
Formatted Diff
Diff
Patch.
(11.41 KB, patch)
2013-08-15 12:39 PDT
,
Hans Muller
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Hans Muller
Comment 1
2013-08-14 17:40:41 PDT
Created
attachment 208777
[details]
Patch Added minimal support for shape-outside image values. A new method that computes the excluded intervals for a horizontal line segment was added to the RasterIntervals class. The stub RasterShape getExcludedIntervals() method has been replaced by one that uses the new method. Image shapes are represented by a RasterIntervals object, which just encapsulates a Region object. The new getExcludedIntervals() method computes the excluded intervals for a horizontal line segment between y1 and y2. To find the excluded intervals we vertically expand each of the image shape Region's rectangles that fall within the line segment, so that they begin at y1 and have height = y2 - y1. The union of the expanded rectangles produces a new Region whose horizontal projection defines the excluded intervals.
Alexandru Chiculita
Comment 2
2013-08-15 12:32:12 PDT
Comment on
attachment 208777
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=208777&action=review
r=me
> LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-image-001-expected.html:24 > + <div id="content">
nit: this node doesn't end. This repeats in all the html files.
Hans Muller
Comment 3
2013-08-15 12:39:25 PDT
Created
attachment 208839
[details]
Patch. Corrected the tests.
WebKit Commit Bot
Comment 4
2013-08-15 16:44:26 PDT
The commit-queue encountered the following flaky tests while processing
attachment 208839
[details]
: http/tests/navigation/ping-cross-origin-from-https.html
bug 51314
(authors:
japhet@chromium.org
and
rniwa@webkit.org
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5
2013-08-15 16:46:15 PDT
Comment on
attachment 208839
[details]
Patch. Clearing flags on attachment: 208839 Committed
r154152
: <
http://trac.webkit.org/changeset/154152
>
WebKit Commit Bot
Comment 6
2013-08-15 16:46:17 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug