117162 – [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code

RESOLVED FIXED 117162

[CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code

https://bugs.webkit.org/show_bug.cgi?id=117162

Summary [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code

Bear Travis

Reported 2013-06-03 12:55:07 PDT

With CSS Exclusions & Shapes splitting into two separate features, some code cleanup is required. http://dev.w3.org/csswg/css-exclusions/ http://dev.w3.org/csswg/css-shapes/ This work will clean up the implementation side. A subsequent patch will clean up the test side.

Attachments
Initial Patch (321.53 KB, patch) 2013-06-03 15:38 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Updated patch (278.90 KB, patch) 2013-06-05 17:34 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Adding directory (279.12 KB, patch) 2013-06-06 11:19 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Adding ShapeOutsideInfo.h to sources (279.25 KB, patch) 2013-06-06 14:20 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Adding folders (280.39 KB, patch) 2013-06-06 15:48 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Updating patch (280.41 KB, patch) 2013-06-06 16:10 PDT, Bear Travis	no flags	Details Formatted Diff Diff
cmakelists additions (283.90 KB, patch) 2013-06-07 11:13 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Updated, incorporating feedback (283.91 KB, patch) 2013-06-10 11:51 PDT, Bear Travis	achicu: review+	Details Formatted Diff Diff
Incorporating feedback (284.00 KB, patch) 2013-06-10 13:38 PDT, Bear Travis	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Bear Travis

Comment 1 2013-06-03 15:38:04 PDT

Created attachment 203633 [details] Initial Patch

Bear Travis

Comment 2 2013-06-05 17:34:44 PDT

Created attachment 203894 [details] Updated patch

Early Warning System Bot

Comment 3 2013-06-05 17:47:52 PDT

Comment on attachment 203894 [details] Updated patch Attachment 203894 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/756256

Early Warning System Bot

Comment 4 2013-06-05 17:49:48 PDT

Comment on attachment 203894 [details] Updated patch Attachment 203894 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/786051

EFL EWS Bot

Comment 5 2013-06-05 17:54:13 PDT

Comment on attachment 203894 [details] Updated patch Attachment 203894 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/709903

EFL EWS Bot

Comment 6 2013-06-05 18:24:02 PDT

Comment on attachment 203894 [details] Updated patch Attachment 203894 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/786052

kov's GTK+ EWS bot

Comment 7 2013-06-05 18:35:30 PDT

Comment on attachment 203894 [details] Updated patch Attachment 203894 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/758687

Bear Travis

Comment 8 2013-06-06 11:19:04 PDT

Created attachment 203953 [details] Adding directory

Early Warning System Bot

Comment 9 2013-06-06 11:26:57 PDT

Comment on attachment 203953 [details] Adding directory Attachment 203953 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/697563

Early Warning System Bot

Comment 10 2013-06-06 11:27:06 PDT

Comment on attachment 203953 [details] Adding directory Attachment 203953 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/790018

EFL EWS Bot

Comment 11 2013-06-06 11:36:59 PDT

Comment on attachment 203953 [details] Adding directory Attachment 203953 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/695650

EFL EWS Bot

Comment 12 2013-06-06 11:38:27 PDT

Comment on attachment 203953 [details] Adding directory Attachment 203953 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/658714

kov's GTK+ EWS bot

Comment 13 2013-06-06 12:23:10 PDT

Comment on attachment 203953 [details] Adding directory Attachment 203953 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/777228

Bear Travis

Comment 14 2013-06-06 14:20:10 PDT

Created attachment 203967 [details] Adding ShapeOutsideInfo.h to sources

Early Warning System Bot

Comment 15 2013-06-06 14:27:36 PDT

Comment on attachment 203967 [details] Adding ShapeOutsideInfo.h to sources Attachment 203967 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/790055

Early Warning System Bot

Comment 16 2013-06-06 14:28:29 PDT

Comment on attachment 203967 [details] Adding ShapeOutsideInfo.h to sources Attachment 203967 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/792010

EFL EWS Bot

Comment 17 2013-06-06 14:31:13 PDT

Comment on attachment 203967 [details] Adding ShapeOutsideInfo.h to sources Attachment 203967 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/772478

EFL EWS Bot

Comment 18 2013-06-06 14:31:56 PDT

Comment on attachment 203967 [details] Adding ShapeOutsideInfo.h to sources Attachment 203967 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/772479

kov's GTK+ EWS bot

Comment 19 2013-06-06 15:44:18 PDT

Comment on attachment 203967 [details] Adding ShapeOutsideInfo.h to sources Attachment 203967 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/792025

Bear Travis

Comment 20 2013-06-06 15:48:14 PDT

Created attachment 203976 [details] Adding folders

Bear Travis

Comment 21 2013-06-06 16:10:19 PDT

Created attachment 203977 [details] Updating patch

EFL EWS Bot

Comment 22 2013-06-06 16:29:04 PDT

Comment on attachment 203977 [details] Updating patch Attachment 203977 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/774331

EFL EWS Bot

Comment 23 2013-06-06 16:33:16 PDT

Comment on attachment 203977 [details] Updating patch Attachment 203977 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/790080

Bear Travis

Comment 24 2013-06-07 11:13:10 PDT

Created attachment 204056 [details] cmakelists additions

Hans Muller

Comment 25 2013-06-07 14:47:13 PDT

It would be helpful if there were a summary of the before/after classnames at the top of the ChangeLog.

Zoltan Horvath

Comment 26 2013-06-07 14:53:54 PDT

Comment on attachment 204056 [details] cmakelists additions View in context: https://bugs.webkit.org/attachment.cgi?id=204056&action=review It looks okay to me. 1 comment: > Source/WebCore/rendering/RenderBlock.cpp:1447 > + ShapeInsideInfo* shapeInsideInfo; nit: you can leave this in the block below as it was before.

Bear Travis

Comment 27 2013-06-10 11:51:28 PDT

Created attachment 204176 [details] Updated, incorporating feedback

Alexandru Chiculita

Comment 28 2013-06-10 13:20:55 PDT

Comment on attachment 204176 [details] Updated, incorporating feedback View in context: https://bugs.webkit.org/attachment.cgi?id=204176&action=review r=me > Source/WebCore/rendering/RenderBlockLineLayout.cpp:118 > + ShapeInsideInfo* shapeInsideInfo = m_block->layoutShapeInsideInfo(); > + if (shapeInsideInfo) nit: The variable could live inside the condition statement. That's more like the WebKit style. > Tools/ChangeLog:8 > + Adding the rendering/shapes directory nit: It looks like you forgot to finish the sentence in the WebKit project Changelogs. "Adding the webcore/rendering/shapes directory to the include list."

Bear Travis

Comment 29 2013-06-10 13:38:11 PDT

Created attachment 204184 [details] Incorporating feedback

WebKit Commit Bot

Comment 30 2013-06-10 14:23:55 PDT

Comment on attachment 204184 [details] Incorporating feedback Clearing flags on attachment: 204184 Committed r151402: <http://trac.webkit.org/changeset/151402>

WebKit Commit Bot

Comment 31 2013-06-10 14:24:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component CSS

Assignee

Bear Travis

Reported

2013-06-03 12:55 PDT

Modified

2013-06-10 14:24 PDT History

CC List

21 users Show

URL

Keywords

Depends on

Blocks

89256 117173

Dependencies

tree graph

cdumez
commit-queue
dino
dstockwell
eflews.bot
esprehn+autocc
giles_joplin
glenn
gtk-ews
gyuyoung.kim
gyuyoung.kim
macpherson
menard
rakuco
rego+ews
simon.fraser
syoichi
WebkitBugTracker
webkit-ews
xan.lopez
zan