116708 – Global constructors exposed in worker environment have wrong attributes

RESOLVED FIXED 116708

Global constructors exposed in worker environment have wrong attributes

https://bugs.webkit.org/show_bug.cgi?id=116708

Summary Global constructors exposed in worker environment have wrong attributes

Chris Dumez

Reported 2013-05-24 00:57:56 PDT

Similar to fast/js/global-constructors-attributes.html but for workers. I would like to add support for generating WorkerContext global constructors in the bindings generator and having such test would help make sure I do not alter the webexposed behavior by doing so.

Attachments
Patch (54.04 KB, patch) 2013-05-24 03:31 PDT, Chris Dumez	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (488.39 KB, application/zip) 2013-05-24 14:46 PDT, Build Bot	no flags	Details
Patch (44.76 KB, patch) 2013-05-24 15:33 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2013-05-24 03:31:27 PDT

Created attachment 202798 [details] Patch Using ews to get mac results.

Build Bot

Comment 2 2013-05-24 14:46:53 PDT

Comment on attachment 202798 [details] Patch Attachment 202798 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/725008 New failing tests: fast/js/global-constructors-attributes-worker.html

Build Bot

Comment 3 2013-05-24 14:46:56 PDT

Created attachment 202852 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Chris Dumez

Comment 4 2013-05-24 15:33:02 PDT

Created attachment 202856 [details] Patch

Geoffrey Garen

Comment 5 2013-05-24 15:48:39 PDT

Comment on attachment 202856 [details] Patch r=me

WebKit Commit Bot

Comment 6 2013-05-24 16:15:30 PDT

Comment on attachment 202856 [details] Patch Clearing flags on attachment: 202856 Committed r150664: <http://trac.webkit.org/changeset/150664>

WebKit Commit Bot

Comment 7 2013-05-24 16:15:34 PDT

All reviewed patches have been landed. Closing bug.

Ryosuke Niwa

Comment 8 2013-05-24 17:35:07 PDT

This patch caused binding tests to fail: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/10301 FAIL: (JS) JSTestObj.cpp --- WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2013-05-11 12:30:58.000000000 -0700 +++ /var/folders/81/qcmw8mp11lvdf69qgyzyl2000000gn/T/tmpDCtYGw/JSTestObj.cpp 2013-05-24 17:08:43.000000000 -0700 @@ -122,13 +122,13 @@ { "conditionalAttr3", DontDelete, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr3), (intptr_t)setJSTestObjConditionalAttr3, NoIntrinsic }, #endif #if ENABLE(Condition1) - { "conditionalAttr4", DontDelete, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr4Constructor), (intptr_t)setJSTestObjConditionalAttr4Constructor, NoIntrinsic }, + { "conditionalAttr4", DontEnum, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr4Constructor), (intptr_t)setJSTestObjConditionalAttr4Constructor, NoIntrinsic }, #endif #if ENABLE(Condition1) && ENABLE(Condition2) - { "conditionalAttr5", DontDelete, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr5Constructor), (intptr_t)setJSTestObjConditionalAttr5Constructor, NoIntrinsic }, + { "conditionalAttr5", DontEnum, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr5Constructor), (intptr_t)setJSTestObjConditionalAttr5Constructor, NoIntrinsic }, #endif #if ENABLE(Condition1) || ENABLE(Condition2) - { "conditionalAttr6", DontDelete, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr6Constructor), (intptr_t)setJSTestObjConditionalAttr6Constructor, NoIntrinsic }, + { "conditionalAttr6", DontEnum, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr6Constructor), (intptr_t)setJSTestObjConditionalAttr6Constructor, NoIntrinsic }, #endif { "cachedAttribute1", DontDelete | ReadOnly, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjCachedAttribute1), (intptr_t)0, NoIntrinsic }, { "cachedAttribute2", DontDelete | ReadOnly, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjCachedAttribute2), (intptr_t)0, NoIntrinsic },

Chris Dumez

Comment 9 2013-05-24 18:14:18 PDT

(In reply to comment #8) > This patch caused binding tests to fail: > http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/10301 > > FAIL: (JS) JSTestObj.cpp > --- WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2013-05-11 12:30:58.000000000 -0700 > +++ /var/folders/81/qcmw8mp11lvdf69qgyzyl2000000gn/T/tmpDCtYGw/JSTestObj.cpp 2013-05-24 17:08:43.000000000 -0700 > @@ -122,13 +122,13 @@ > { "conditionalAttr3", DontDelete, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr3), (intptr_t)setJSTestObjConditionalAttr3, NoIntrinsic }, > #endif > #if ENABLE(Condition1) > - { "conditionalAttr4", DontDelete, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr4Constructor), (intptr_t)setJSTestObjConditionalAttr4Constructor, NoIntrinsic }, > + { "conditionalAttr4", DontEnum, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr4Constructor), (intptr_t)setJSTestObjConditionalAttr4Constructor, NoIntrinsic }, > #endif > #if ENABLE(Condition1) && ENABLE(Condition2) > - { "conditionalAttr5", DontDelete, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr5Constructor), (intptr_t)setJSTestObjConditionalAttr5Constructor, NoIntrinsic }, > + { "conditionalAttr5", DontEnum, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr5Constructor), (intptr_t)setJSTestObjConditionalAttr5Constructor, NoIntrinsic }, > #endif > #if ENABLE(Condition1) || ENABLE(Condition2) > - { "conditionalAttr6", DontDelete, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr6Constructor), (intptr_t)setJSTestObjConditionalAttr6Constructor, NoIntrinsic }, > + { "conditionalAttr6", DontEnum, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConditionalAttr6Constructor), (intptr_t)setJSTestObjConditionalAttr6Constructor, NoIntrinsic }, > #endif > { "cachedAttribute1", DontDelete | ReadOnly, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjCachedAttribute1), (intptr_t)0, NoIntrinsic }, > { "cachedAttribute2", DontDelete | ReadOnly, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjCachedAttribute2), (intptr_t)0, NoIntrinsic }, Sorry, I failed to rebaseline those. I didn't realize Constructor attributes were covered.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

Chris Dumez

Reported

2013-05-24 00:57 PDT

Modified

2013-05-24 18:14 PDT History

CC List

11 users Show

URL

http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces

Keywords WebExposed

Depends on

Blocks

116660

Dependencies

tree graph