RESOLVED FIXED 116530
Remove custom code for webkitAudioContext global constructor getter 
https://bugs.webkit.org/show_bug.cgi?id=116530
Summary Remove custom code for webkitAudioContext global constructor getter
Chris Dumez
Reported 2013-05-21 03:47:45 PDT
webkitAudioContext global constructor getter on DOMWindow.idl currently has a [CustomGetter] because the attribute can be disabled at runtime via the WebAudioEnabled setting. We should use the RuntimeTimeEnabled class for this instead of regular settings and use [EnableAtRuntime] extended attribute so that we can automatically generate the global constructor for AudioContext.
Attachments
Patch (34.53 KB, patch)
2013-05-21 05:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (34.93 KB, patch)
2013-05-21 05:16 PDT, Chris Dumez 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (36.23 KB, patch)
2013-05-21 05:59 PDT, Chris Dumez 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (36.23 KB, patch)
2013-05-21 06:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (36.15 KB, patch)
2013-05-22 05:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-05-21 05:12:42 PDT
Created attachment 202414 [details] Patch
Chris Dumez
Comment 2 2013-05-21 05:16:43 PDT
Created attachment 202415 [details] Patch Add missing WEB_AUDIO #ifdef
Build Bot
Comment 3 2013-05-21 05:49:18 PDT
Comment on attachment 202415 [details] Patch Attachment 202415 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/422238
Chris Dumez
Comment 4 2013-05-21 05:59:48 PDT
Created attachment 202419 [details] Patch Export extra symbol to fix mac build.
Build Bot
Comment 5 2013-05-21 06:21:54 PDT
Comment on attachment 202419 [details] Patch Attachment 202419 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/516206
Chris Dumez
Comment 6 2013-05-21 06:23:52 PDT
Created attachment 202425 [details] Patch
Chris Dumez
Comment 7 2013-05-22 05:08:15 PDT
Created attachment 202525 [details] Patch Rebase on master due to conflict with Bug 116520.
Gyuyoung Kim
Comment 8 2013-05-22 19:36:11 PDT
Comment on attachment 202525 [details] Patch Looks nice refactoring. Looks fine on EFL port side.
Chris Dumez
Comment 9 2013-05-24 14:21:42 PDT
Could someone please review this patch? Thanks.
Geoffrey Garen
Comment 10 2013-05-24 14:46:15 PDT
Comment on attachment 202525 [details] Patch r=me
WebKit Commit Bot
Comment 11 2013-05-24 15:57:13 PDT
Comment on attachment 202525 [details] Patch Clearing flags on attachment: 202525 Committed r150663: <http://trac.webkit.org/changeset/150663>
WebKit Commit Bot
Comment 12 2013-05-24 15:57:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.