RESOLVED INVALID 114680
[Qt][Wk2] REGRESSION(r148300): It made some qmltests API test fail 
https://bugs.webkit.org/show_bug.cgi?id=114680
Summary [Qt][Wk2] REGRESSION(r148300): It made some qmltests API test fail
Ádám Kallai
Reported 2013-04-16 05:53:28 PDT
FAIL! : qmltests::DoubleTapToZoom::test_basic_zoomInAndBack() Compared values are not the same Actual (): 1.3333333730697632 Expected (): 1 Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2pixel/buildslave/qt-linux-64-release-webkit2-pixel/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml(99)] FAIL! : qmltests::DoubleTapToZoom::test_double_zoomInAndBack() Compared values are not the same Actual (): 240x180 Expected (): 320x240 Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2pixel/buildslave/qt-linux-64-release-webkit2-pixel/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml(106)] FAIL! : qmltests::DoubleTapToZoom::test_double_zoomInAndBack2() Compared values are not the same Actual (): 1.3333333730697632 Expected (): 2 Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2pixel/buildslave/qt-linux-64-release-webkit2-pixel/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml(150)] FAIL! : qmltests::DoubleTapToZoom::test_double_zoomInOutAndBack() Compared values are not the same Actual (): 240x180 Expected (): 320x240 Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2pixel/buildslave/qt-linux-64-release-webkit2-pixel/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml(166)] FAIL! : qmltests::DoubleTapToZoom::test_double_zoomInOutAndBack2() Compared values are not the same Actual (): 2 Expected (): 1.3333333333333333 Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2pixel/buildslave/qt-linux-64-release-webkit2-pixel/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml(211)] FAIL! : qmltests::Resize::test_resizeAfterNeutralZoom() Compared values are not the same Actual (): 1.2307692766189575 Expected (): 1 Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2pixel/buildslave/qt-linux-64-release-webkit2-pixel/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml(124)] FAIL! : qmltests::Resize::test_resizeZoomedIn() Compared values are not the same Actual (): 1.2307692766189575 Expected (): 1 Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2pixel/buildslave/qt-linux-64-release-webkit2-pixel/build/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml(143)] PASS : qmltests::Resize::cleanupTestCase()
Attachments
Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2013-04-16 06:03:17 PDT
At least for the double tap test I don't recall the last time it passed (months at least). Was there really regressions?
Ádám Kallai
Comment 2 2013-04-16 08:05:48 PDT
I think it is. Because I have been looking for older logs. These API tests were failing in the 144421 for the last time. http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/builds/2667 What do you think?
Jocelyn Turcotte
Comment 3 2013-04-16 08:22:44 PDT
(In reply to comment #2) > I think it is. Because I have been looking for older logs. These API tests were failing in the 144421 for the last time. > > http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/builds/2667 > > What do you think? You're right, this has probably been fixed by http://trac.webkit.org/changeset/144440 then. I'm not sure how 148300 could have broken it, but the modification to WebPage.cpp might have something to do with it.
Ádám Kallai
Comment 4 2013-04-16 09:51:24 PDT
I don't know how, either, but I checked it in local and this revision is responsible. > You're right, this has probably been fixed by http://trac.webkit.org/changeset/144440 then. > I'm not sure how 148300 could have broken it, but the modification to WebPage.cpp might have something to do with it.
Gábor Ábrahám
Comment 5 2013-07-03 06:28:17 PDT
*** Bug 118357 has been marked as a duplicate of this bug. ***
Tim Horton
Comment 6 2013-07-05 16:21:34 PDT
That seems surprising! Maybe the other ports are depending on the repaint-the-world that I removed?
Gábor Ábrahám
Comment 7 2013-07-10 07:41:54 PDT
This change make the API tests fail: http://trac.webkit.org/changeset/148300/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Jocelyn Turcotte
Comment 8 2014-02-03 03:25:40 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.