RESOLVED FIXED 114280
svg/animations/smil-leak-*.svg tests are flaky 
https://bugs.webkit.org/show_bug.cgi?id=114280
Summary svg/animations/smil-leak-*.svg tests are flaky
WebKit Commit Bot
Reported 2013-04-09 06:39:29 PDT
This is an automatically generated bug from the commit-queue. svg/animations/smil-leak-elements.svg has been flaky on the commit-queue. svg/animations/smil-leak-elements.svg was authored by fmalita@chromium.org and timothy_horton@apple.com. http://trac.webkit.org/browser/trunk/LayoutTests/svg/animations/smil-leak-elements.svg The commit-queue just saw svg/animations/smil-leak-elements.svg flake (text diff) while processing attachment 197034 [details] on bug 85934. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Attachments
Archive of layout-test-results from webkit-cq-02 (544.91 KB, application/zip)
2013-04-09 06:39 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-02 (545.51 KB, application/zip)
2013-04-16 13:15 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-03 (543.46 KB, application/zip)
2013-04-19 08:59 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-03 (544.75 KB, application/zip)
2013-04-24 19:07 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-02 (544.10 KB, application/zip)
2013-05-06 08:35 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-01 (565.10 KB, application/zip)
2013-05-22 09:01 PDT, WebKit Commit Bot 		no flags
Details
speculative fix (7.97 KB, patch)
2013-09-12 13:55 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
another speculative fix (5.59 KB, patch)
2013-09-16 10:33 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 (1018.96 KB, application/zip)
2017-07-28 03:26 PDT, WebKit Commit Bot 		no flags
Details
Patch (7.71 KB, patch)
2022-07-05 14:13 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (7.70 KB, patch)
2022-07-05 17:24 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (7.71 KB, patch)
2022-07-05 19:32 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2013-04-09 06:39:31 PDT
Created attachment 197070 [details] Archive of layout-test-results from webkit-cq-02
WebKit Commit Bot
Comment 2 2013-04-16 13:15:21 PDT
The commit-queue just saw svg/animations/smil-leak-elements.svg flake (text diff) while processing attachment 198387 [details] on bug 108980. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
WebKit Commit Bot
Comment 3 2013-04-16 13:15:22 PDT
Created attachment 198394 [details] Archive of layout-test-results from webkit-cq-02
WebKit Commit Bot
Comment 4 2013-04-19 08:59:06 PDT
The commit-queue just saw svg/animations/smil-leak-elements.svg flake (text diff) while processing attachment 198850 [details] on bug 109588. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
WebKit Commit Bot
Comment 5 2013-04-19 08:59:07 PDT
Created attachment 198887 [details] Archive of layout-test-results from webkit-cq-03
WebKit Commit Bot
Comment 6 2013-04-24 19:07:08 PDT
The commit-queue just saw svg/animations/smil-leak-elements.svg flake (text diff) while processing attachment 199517 [details] on bug 114218. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
WebKit Commit Bot
Comment 7 2013-04-24 19:07:10 PDT
Created attachment 199605 [details] Archive of layout-test-results from webkit-cq-03
WebKit Commit Bot
Comment 8 2013-05-06 08:35:25 PDT
The commit-queue just saw svg/animations/smil-leak-elements.svg flake (text diff) while processing attachment 200427 [details] on bug 114742. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
WebKit Commit Bot
Comment 9 2013-05-06 08:35:26 PDT
Created attachment 200678 [details] Archive of layout-test-results from webkit-cq-02
WebKit Commit Bot
Comment 10 2013-05-22 09:01:45 PDT
The commit-queue just saw svg/animations/smil-leak-elements.svg flake (text diff) while processing attachment 202536 [details] on bug 116605. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
WebKit Commit Bot
Comment 11 2013-05-22 09:01:47 PDT
Created attachment 202540 [details] Archive of layout-test-results from webkit-cq-01
Alexey Proskuryakov
Comment 12 2013-09-12 13:49:24 PDT
*** Bug 114281 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 13 2013-09-12 13:55:16 PDT
Created attachment 211471 [details] speculative fix
Tim Horton
Comment 14 2013-09-12 13:56:23 PDT
Comment on attachment 211471 [details] speculative fix Seems reasonable to me.
Alexey Proskuryakov
Comment 15 2013-09-12 14:01:55 PDT
Committed <http://trac.webkit.org/r155648>.
Alexey Proskuryakov
Comment 16 2013-09-13 10:35:03 PDT
This didn't help.
Alexey Proskuryakov
Comment 17 2013-09-13 16:00:08 PDT
Increased the number of nodes in the tests 10x in <http://trac.webkit.org/r155728> to see what happens (if the number of leaked nodes grows accordingly, we're more likely to have a real bug).
Alexey Proskuryakov
Comment 18 2013-09-16 10:33:04 PDT
Created attachment 211808 [details] another speculative fix
Geoffrey Garen
Comment 19 2013-09-16 10:35:20 PDT
Comment on attachment 211808 [details] another speculative fix r=me
Alexey Proskuryakov
Comment 20 2013-09-16 10:39:14 PDT
Committed <http://trac.webkit.org/r155882>.
Alexey Proskuryakov
Comment 21 2013-09-16 12:35:43 PDT
And that didn't help either. Changed timeouts from 0 to 100 ms as suggested by Geoff on IRC: <http://trac.webkit.org/r155890>.
Alexey Proskuryakov
Comment 22 2013-09-16 13:17:30 PDT
Still failing, no change at all (seeing between 4 and 14 leaked nodes).
Alexey Proskuryakov
Comment 23 2013-09-16 13:34:33 PDT
Marked as flaky in <http://trac.webkit.org/r155897>. This seems more like a real WebKit bug now, the tests are doing everything possible to perform a complete garbage collection.
Geoffrey Garen
Comment 24 2013-09-16 17:04:37 PDT
> Marked as flaky in <http://trac.webkit.org/r155897>. I really don't like the "flaky" as a solution to a failing test. It's net negative information. If a bot watcher or engineer ever sets aside productive work to diagnose a red bot because of these broken tests, the tests will have been a net detriment to the project. It would be better not to run these tests, or to run them to test for crashes, and completely ignore other output. Another better option would be to give the tests a tolerance for some percentage of surviving Nodes. Then, they could still test for a traditional storage leak, which would exceed the tolerance.
Alexey Proskuryakov
Comment 25 2013-09-16 17:37:22 PDT
> or to run them to test for crashes, and completely ignore other output. That's pretty much exactly what marking as flaky does - the test won't make bots red unless it starts to crash. Plus flakiness console may one day tell us that the underlying bug disappeared, so we can remove the entries from TestExpectations.
Said Abou-Hallawa
Comment 26 2015-03-11 13:08:54 PDT
Committed r181401: <http://trac.webkit.org/changeset/181401>
Said Abou-Hallawa
Comment 27 2015-03-11 13:10:00 PDT
Change http://trac.webkit.org/changeset/181401 marks these test to be flaky on all ports.
WebKit Commit Bot
Comment 28 2017-07-28 03:26:33 PDT
The commit-queue just saw svg/animations/smil-leak-dynamically-added-element-instances.svg flake (text diff) while processing attachment 316629 [details] on bug 173419. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 29 2017-07-28 03:26:34 PDT
Created attachment 316631 [details] Archive of layout-test-results from webkit-cq-03
Fujii Hironori
Comment 30 2022-07-05 14:13:46 PDT
Created attachment 460693 [details] Patch
Fujii Hironori
Comment 31 2022-07-05 14:14:37 PDT
*** Bug 175867 has been marked as a duplicate of this bug. ***
Fujii Hironori
Comment 32 2022-07-05 14:14:47 PDT
*** Bug 175886 has been marked as a duplicate of this bug. ***
Fujii Hironori
Comment 33 2022-07-05 14:15:00 PDT
*** Bug 174180 has been marked as a duplicate of this bug. ***
Fujii Hironori
Comment 34 2022-07-05 17:24:47 PDT
Created attachment 460697 [details] Patch
Fujii Hironori
Comment 35 2022-07-05 19:32:34 PDT
Created attachment 460703 [details] Patch
EWS
Comment 36 2022-07-07 22:12:13 PDT
Committed 252260@main (56cbe674213b): <https://commits.webkit.org/252260@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460703 [details].
Radar WebKit Bug Importer
Comment 37 2022-07-07 22:13:18 PDT
<rdar://problem/96648276>
Note You need to log in before you can comment on or make changes to this bug.