WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
113351
[CSS Grid Layout] Before / start paddings and borders are not accounted for when placing the grid items
https://bugs.webkit.org/show_bug.cgi?id=113351
Summary
[CSS Grid Layout] Before / start paddings and borders are not accounted for w...
Julien Chaffraix
Reported
2013-03-26 16:03:42 PDT
Putting the following on the grid container (grid element before): padding: 20px; doesn't add the top and left padding (see test case).
Attachments
Test case, there should be some grey above and left of the colored squares
(639 bytes, text/html)
2013-03-26 21:04 PDT
,
Julien Chaffraix
no flags
Details
Proposed fix 1: Add the borders and paddings before / start.
(27.94 KB, patch)
2013-03-27 20:10 PDT
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2013-03-26 21:03:46 PDT
I misinterpreted the issue. The grid container is properly sized but the grid items ignore any paddings (and probably borders).
Julien Chaffraix
Comment 2
2013-03-26 21:04:23 PDT
Created
attachment 195216
[details]
Test case, there should be some grey above and left of the colored squares
Julien Chaffraix
Comment 3
2013-03-27 20:10:13 PDT
Created
attachment 195468
[details]
Proposed fix 1: Add the borders and paddings before / start.
WebKit Review Bot
Comment 4
2013-03-28 12:22:20 PDT
Comment on
attachment 195468
[details]
Proposed fix 1: Add the borders and paddings before / start. Clearing flags on attachment: 195468 Committed
r147140
: <
http://trac.webkit.org/changeset/147140
>
WebKit Review Bot
Comment 5
2013-03-28 12:22:23 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug