WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111505
Remove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=111505
Summary
Remove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
Julien Chaffraix
Reported
2013-03-05 18:08:58 PST
While working on a change, I discovered that most people add handling for shorthands inside either StyleResolver or StyleBuilder (you can check that all of the shorthands are mentioned at some point). However we do expand most shorthands** to their longhands during parsing so all this code is effectively dead. The main issue is that people don't know about the previous expansion and thus repeat what the old code did. If we remove this code, we need to add some ASSERTs to ensure that people don't fall back into copying and pasting. ** The only exception is 'font' which is special due to system fonts (but we handle it in a way that is not compliant with CSS 3 Fonts)
Attachments
Proposed removal and refactoring. Should prevent future abuse. The ASSERT will trigger without bug 111481.
(47.14 KB, patch)
2013-03-05 18:29 PST
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2013-03-05 18:29:07 PST
Created
attachment 191631
[details]
Proposed removal and refactoring. Should prevent future abuse. The ASSERT will trigger without
bug 111481
.
Andreas Kling
Comment 2
2013-03-06 04:20:28 PST
This looks like a great idea. :)
Alexis Menard (darktears)
Comment 3
2013-03-06 04:25:05 PST
(In reply to
comment #2
)
> This looks like a great idea. :)
It is. The patch needed has landed. I'll put that in EWS soon and review it.
Alexis Menard (darktears)
Comment 4
2013-03-06 05:18:36 PST
r=me. awesome cleanup!
WebKit Review Bot
Comment 5
2013-03-06 05:33:21 PST
Comment on
attachment 191631
[details]
Proposed removal and refactoring. Should prevent future abuse. The ASSERT will trigger without
bug 111481
. Clearing flags on attachment: 191631 Committed
r144912
: <
http://trac.webkit.org/changeset/144912
>
WebKit Review Bot
Comment 6
2013-03-06 05:33:25 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug