RESOLVED FIXED 110643
Teach the html5lib tests how to test the threaded HTML parser 
https://bugs.webkit.org/show_bug.cgi?id=110643
Summary Teach the html5lib tests how to test the threaded HTML parser
Eric Seidel (no email)
Reported 2013-02-22 14:10:11 PST
Teach the html5lib tests how to test the threaded HTML parser
Attachments
Patch (21.79 KB, patch)
2013-02-22 14:11 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2013-02-22 14:11:04 PST
Created attachment 189823 [details] Patch
WebKit Review Bot
Comment 2 2013-02-22 14:41:39 PST
Comment on attachment 189823 [details] Patch Rejecting attachment 189823 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189823, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16708300
WebKit Review Bot
Comment 3 2013-02-22 14:59:00 PST
Comment on attachment 189823 [details] Patch Clearing flags on attachment: 189823 Committed r143804: <http://trac.webkit.org/changeset/143804>
WebKit Review Bot
Comment 4 2013-02-22 14:59:04 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 5 2013-02-22 17:52:34 PST
This patch appears to have broken 3 html5lib tests on Mac WK1: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/7172
Eric Seidel (no email)
Comment 6 2013-02-22 17:54:05 PST
I'm sure it didn't break anything. :) I suspect I just rebaselined from Chromium and previously chromium was using its own baselines for that test. Just needs gardening.
Ryosuke Niwa
Comment 7 2013-02-22 17:54:43 PST
(In reply to comment #6) > I'm sure it didn't break anything. :) I suspect I just rebaselined from Chromium and previously chromium was using its own baselines for that test. Just needs gardening. Oh, it seems like you just didn't rebaseline those tests. Maybe they're disabled on Chromium?
Eric Seidel (no email)
Comment 8 2013-02-22 17:58:18 PST
That's also possible? Not sure. I can't remember if we have different results for v8 for some of these tests. :(
Ryosuke Niwa
Comment 9 2013-02-22 17:59:23 PST
(In reply to comment #8) > That's also possible? Not sure. I can't remember if we have different results for v8 for some of these tests. :( You didn't baseline 1, 7, & 18 in http://trac.webkit.org/changeset/143804, and that's exactly the set of tests failing on bots. I'm rebaselining them now.
Eric Seidel (no email)
Comment 10 2013-02-22 18:00:59 PST
Thank you very much.
Ryosuke Niwa
Comment 11 2013-02-22 18:01:47 PST
(In reply to comment #9) > (In reply to comment #8) > > That's also possible? Not sure. I can't remember if we have different results for v8 for some of these tests. :( > > You didn't baseline 1, 7, & 18 in http://trac.webkit.org/changeset/143804, and that's exactly the set of tests failing on bots. I'm rebaselining them now. Done that in http://trac.webkit.org/changeset/143823.
Adam Barth
Comment 12 2013-02-22 18:05:11 PST
I bet that means they're skipped in Chromium. We should double-check them in the threaded parser.
Ryosuke Niwa
Comment 13 2013-02-22 18:55:36 PST
(In reply to comment #12) > I bet that means they're skipped in Chromium. We should double-check them in the threaded parser. I misspoke. They have chromium-specific results due to parser error being different on JSC/V8 :(
WebKit Review Bot
Comment 14 2013-02-25 00:15:33 PST
Re-opened since this is blocked by bug 110729
Ryosuke Niwa
Comment 15 2013-02-25 03:32:08 PST
Closing the bug again since the rollout bugs have been closed as invalid.
Note You need to log in before you can comment on or make changes to this bug.