RESOLVED FIXED 110072
Get rid of DFG::DoubleOperand and simplify ValueToInt32 
https://bugs.webkit.org/show_bug.cgi?id=110072
Summary Get rid of DFG::DoubleOperand and simplify ValueToInt32
Filip Pizlo
Reported 2013-02-17 19:52:57 PST
The only remaining use of it is actually somewhat wrong.
Attachments
the patch (36.35 KB, patch)
2013-02-17 22:38 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (41.50 KB, patch)
2013-02-18 00:03 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-02-17 21:27:12 PST
Actually ValueToInt32, the only use of DoubleOperand, was not just slightly wrong. It was totally borked. Repro case: function foo(a, b) { var result = a | b.f; return [result, a]; } var counter = 0; for (var i = 0; i < 100; ++i) { var result = foo({valueOf:function() { counter++; return 1; }}, {f:i == 99 ? 5.5 : 5}); if (result.length != 2) throw "error"; if (result[0] != 5) throw "error"; } if (counter != 100) throw "error";
Filip Pizlo
Comment 2 2013-02-17 22:38:34 PST
Created attachment 188799 [details] the patch Still need to generate the results file. But other than that it's good to go.
Filip Pizlo
Comment 3 2013-02-18 00:03:36 PST
Created attachment 188804 [details] the patch
Geoffrey Garen
Comment 4 2013-02-18 05:58:54 PST
Comment on attachment 188804 [details] the patch r=me
Filip Pizlo
Comment 5 2013-02-18 10:42:04 PST
Landed in http://trac.webkit.org/changeset/143241
Csaba Osztrogonác
Comment 6 2013-02-18 23:15:48 PST
(In reply to comment #5) > Landed in http://trac.webkit.org/changeset/143241 It caused a serious regression on 32 bit platforms. See https://bugs.webkit.org/show_bug.cgi?id=110184 for details.
Filip Pizlo
Comment 7 2013-02-20 14:28:17 PST
*** Bug 101434 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.