Created attachment 186542 [details] Patch

Comment on attachment 186542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186542&action=review This is fantastic. One minor issue. r=me > LayoutTests/platform/chromium/TestExpectations:1434 > +crbug.com/172368 webgl/conformance/attribs/gl-vertex-attrib-zero-issues.html [ Skip ] This isn't the correct bug ID. Could you update it?

Created attachment 186670 [details] Patch

Created attachment 186689 [details] Patch

Created attachment 186765 [details] Patch

Created attachment 186768 [details] Patch

Committed r141971: <http://trac.webkit.org/changeset/141971>

Three webgl tests fail on Qt. The last one landed in r141911. Do you have any idea? Thanks. * webgl/conformance/attribs/gl-vertex-attrib-render.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/attribs/gl-vertex-attrib-render-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/attribs/gl-vertex-attrib-render-actual.txt @@ -1,5 +1,5 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-render.html -PASS +FAIL * webgl/conformance/attribs/gl-vertexattribpointer-offsets.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/attribs/gl-vertexattribpointer-offsets-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/attribs/gl-vertexattribpointer-offsets-actual.txt @@ -1,5 +1,5 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer-offsets.html -PASS +FAIL * webgl/conformance/misc/delayed-drawing.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/misc/delayed-drawing-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/webgl/conformance/misc/delayed-drawing-actual.txt @@ -1,5 +1,5 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/misc/delayed-drawing.html -PASS +FAIL

I forgot something: stderr contains: "failed to create drawable." By the way WebGL is disabled on Qt so webgl tests shouldn't be run.

Sorry about that. This patch is supposed to make it skip ports that don't support WebGL. Any idea why this isn't working for qt?

(In reply to comment #10) > Sorry about that. > > This patch is supposed to make it skip ports that don't support WebGL. Oops: https://bugs.webkit.org/show_bug.cgi?id=108705 > > Any idea why this isn't working for qt?

Hi do you mind adding any webgl tests in to the Windows skip list? LayoutTests/platform/win/TestExpectations There should be a section with disabled webgl tests. I've added some of the recently added conformance tests to it but it looks like there are sitll more rolling in. http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r141971%20(32095)/results.html Could you skip those and any future webgl-conformance tests added? Thanks

Do you need all WebGL tests disabled in Windows or just the tests that fail on mac?

All of em! WebGL isn't implement on the Apple Windows port :(... Thanks again!

gl-vertexattribpointer.html is timing out on Debug Chromium bots. I'll mark it in TestExpectations. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=webgl%2Fconformance%2Fattribs%2Fgl-vertexattribpointer.html

(In reply to comment #15) > gl-vertexattribpointer.html is timing out on Debug Chromium bots. I'll mark it in TestExpectations. > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=webgl%2Fconformance%2Fattribs%2Fgl-vertexattribpointer.html can you mark it as slow? It is a slow test.

(In reply to comment #16) > can you mark it as slow? It is a slow test. Done!

Comment on attachment 186768 [details] Patch Cleared review? from attachment 186768 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).