WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107817
Web Inspector: "XHR loaded!" messages should be DebugMessageLevel.
https://bugs.webkit.org/show_bug.cgi?id=107817
Summary
Web Inspector: "XHR loaded!" messages should be DebugMessageLevel.
Mike West
Reported
2013-01-24 06:09:38 PST
We currently allow users to opt-in to displaying messages when XHR loads successfully. These shouldn't be LogMessageLevel; that should be reserved for user-generated messages (`console.XXX()` calls).
Attachments
Patch
(1.95 KB, patch)
2013-01-24 06:25 PST
,
Mike West
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mike West
Comment 1
2013-01-24 06:19:03 PST
It also shouldn't be "LogMessageType", but "NetworkMessageType". Patch in a moment.
Mike West
Comment 2
2013-01-24 06:25:49 PST
Created
attachment 184481
[details]
Patch
WebKit Review Bot
Comment 3
2013-01-24 08:02:00 PST
Comment on
attachment 184481
[details]
Patch Rejecting
attachment 184481
[details]
from commit-queue. New failing tests: fast/repaint/selection-clear.html Full output:
http://queues.webkit.org/results/16073816
Mike West
Comment 4
2013-01-24 12:42:50 PST
Comment on
attachment 184481
[details]
Patch It looks like the test is a flake; let's try the CQ again.
WebKit Review Bot
Comment 5
2013-01-24 15:18:51 PST
Comment on
attachment 184481
[details]
Patch Clearing flags on attachment: 184481 Committed
r140733
: <
http://trac.webkit.org/changeset/140733
>
WebKit Review Bot
Comment 6
2013-01-24 15:18:54 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug