RESOLVED FIXED 107755
Teach threaded HTML parser to update InspectorInstrumentation when writing HTML 
https://bugs.webkit.org/show_bug.cgi?id=107755
Summary Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
Tony Gentilcore
Reported 2013-01-23 16:23:29 PST
Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
Attachments
Patch (2.88 KB, patch)
2013-01-23 16:24 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2013-01-23 16:54 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2013-01-23 16:24:53 PST
Created attachment 184338 [details] Patch
Eric Seidel (no email)
Comment 2 2013-01-23 16:42:25 PST
Comment on attachment 184338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184338&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:284 > + InspectorInstrumentationCookie cookie = InspectorInstrumentation::willWriteHTML(document(), 0, 0); We have the line number, we could easily pass it here. :) > Source/WebCore/html/parser/HTMLDocumentParser.cpp:313 > + InspectorInstrumentation::didWriteHTML(cookie, 0); Similarly here, lineNumber() should just be correct already. :)
Tony Gentilcore
Comment 3 2013-01-23 16:54:09 PST
Created attachment 184350 [details] Patch
Tony Gentilcore
Comment 4 2013-01-23 16:57:05 PST
> Similarly here, lineNumber() should just be correct already. :) You are right. Fixed.
Eric Seidel (no email)
Comment 5 2013-01-23 16:59:25 PST
Comment on attachment 184350 [details] Patch LGTM. It would be easy to wire the input length into the "packets of tokens" sent back from the background parser, but we can do that in a second pass.
WebKit Review Bot
Comment 6 2013-01-23 18:18:53 PST
Comment on attachment 184350 [details] Patch Clearing flags on attachment: 184350 Committed r140628: <http://trac.webkit.org/changeset/140628>
WebKit Review Bot
Comment 7 2013-01-23 18:18:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.