WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
107662
[WK2][EFL] Ewk_View implementation should use C WK2 API and not C++ internals
https://bugs.webkit.org/show_bug.cgi?id=107662
Summary
[WK2][EFL] Ewk_View implementation should use C WK2 API and not C++ internals
Mikhail Pozdnyakov
Reported
2013-01-23 04:16:21 PST
SSIA
Attachments
Add attachment
proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1
2013-01-23 12:17:56 PST
Having had a discussion with Kenneth, came to the following Ewk_View refactoring plan: 1) Existing EwkViewImpl class code and Ewk_view smart object code will be distributed between two new classes: WebView and EwkView 2) WebView class will be located inside WebKit2 folder (uiprocess/efl). This class is intended to be minimal and just expose the WK2 internals we need; it will be EFL-agnostic meaning we avoid Evas constructs in it. 3) WebView class will not be exported, instead it will have exported wrapping C WKView API(api/c/efl), including client API. 4) EwkView class will be located outside of WebKit2 folder. This class will include the glue code between EFL (Evas) and WebView. Besides EwkView will support WebView client interface.
Chris Dumez
Comment 2
2013-01-23 12:22:01 PST
(In reply to
comment #1
)
> Having had a discussion with Kenneth, came to the following Ewk_View refactoring plan: > 1) Existing EwkViewImpl class code and Ewk_view smart object code will be > distributed between two new classes: WebView and EwkView > > 2) WebView class will be located inside WebKit2 folder (uiprocess/efl). > This class is intended to be minimal and just expose the WK2 internals we need; it will be EFL-agnostic meaning we avoid Evas constructs in it. > > 3) WebView class will not be exported, instead it will have exported wrapping C WKView API(api/c/efl), including client API. > > 4) EwkView class will be located outside of WebKit2 folder. This class will include the glue code between EFL (Evas) and WebView. Besides EwkView will > support WebView client interface.
Why does EwkView need to be outside the WebKit2 folder?
Kenneth Rohde Christiansen
Comment 3
2013-01-23 14:09:11 PST
(In reply to
comment #2
)
> (In reply to
comment #1
) > > Having had a discussion with Kenneth, came to the following Ewk_View refactoring plan: > > 1) Existing EwkViewImpl class code and Ewk_view smart object code will be > > distributed between two new classes: WebView and EwkView > > > > 2) WebView class will be located inside WebKit2 folder (uiprocess/efl). > > This class is intended to be minimal and just expose the WK2 internals we need; it will be EFL-agnostic meaning we avoid Evas constructs in it. > > > > 3) WebView class will not be exported, instead it will have exported wrapping C WKView API(api/c/efl), including client API. > > > > 4) EwkView class will be located outside of WebKit2 folder. This class will include the glue code between EFL (Evas) and WebView. Besides EwkView will > > support WebView client interface. > > Why does EwkView need to be outside the WebKit2 folder?
It will be in UIProcess/API/efl so not actually outside WebKit2 folder, but in the EFL-API area.
Gyuyoung Kim
Comment 4
2013-01-23 18:02:38 PST
(In reply to
comment #1
)
> Having had a discussion with Kenneth, came to the following Ewk_View refactoring plan: > 1) Existing EwkViewImpl class code and Ewk_view smart object code will be > distributed between two new classes: WebView and EwkView
It looks this is meaningful work only when we decide to move APIs to Source/WebKit/efl-wk2, right ?
Mikhail Pozdnyakov
Comment 5
2013-01-23 23:47:01 PST
(In reply to
comment #4
)
> (In reply to
comment #1
) > > Having had a discussion with Kenneth, came to the following Ewk_View refactoring plan: > > 1) Existing EwkViewImpl class code and Ewk_view smart object code will be > > distributed between two new classes: WebView and EwkView > > It looks this is meaningful work only when we decide to move APIs to Source/WebKit/efl-wk2, right ?
I would say that moving of EwkView out of WebKit2 folder should be done when we decide to move our APIs. The rest of work should be done at the moment, so that we fix holes in WK2 API layering.
Michael Catanzaro
Comment 6
2017-03-11 10:52:25 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug