RESOLVED FIXED 107596
Fix assertions in make8BitFrom16BitSource() with threaded parser 
https://bugs.webkit.org/show_bug.cgi?id=107596
Summary Fix assertions in make8BitFrom16BitSource() with threaded parser
Tony Gentilcore
Reported 2013-01-22 15:36:53 PST
Fix assertions in make8BitFrom16BitSource() with threaded parser
Attachments
Patch (3.92 KB, patch)
2013-01-22 15:38 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2013-01-22 15:38:06 PST
Created attachment 184062 [details] Patch
Adam Barth
Comment 2 2013-01-22 16:01:17 PST
Comment on attachment 184062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184062&action=review > Source/WebCore/html/parser/HTMLToken.h:245 > m_externalCharacters = token.data().characters(); > m_externalCharactersLength = token.data().length(); > + m_isAll8BitData = token.isAll8BitData(); This change is fine, but I think we'll need to rethink this "external characters" design as part of this work.
WebKit Review Bot
Comment 3 2013-01-22 16:08:04 PST
Comment on attachment 184062 [details] Patch Clearing flags on attachment: 184062 Committed r140485: <http://trac.webkit.org/changeset/140485>
WebKit Review Bot
Comment 4 2013-01-22 16:08:07 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 5 2013-01-22 16:24:12 PST
Comment on attachment 184062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184062&action=review >> Source/WebCore/html/parser/HTMLToken.h:245 >> + m_isAll8BitData = token.isAll8BitData(); > > This change is fine, but I think we'll need to rethink this "external characters" design as part of this work. Agreed.
Note You need to log in before you can comment on or make changes to this bug.