WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107386
[SVG2] Merge SVGStyledElement and SVGElement
https://bugs.webkit.org/show_bug.cgi?id=107386
Summary
[SVG2] Merge SVGStyledElement and SVGElement
Philip Rogers
Reported
2013-01-19 17:24:23 PST
SVG2 updates the class hierarchy so all SVGElements are styled. We should merge SVGStyledElement into SVGElement. SVG2 updated spec for SVGElement:
https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement
A comparison of SVG 1.1 and SVG 2:
https://docs.google.com/a/google.com/drawings/d/1DjmqGOk71JATh5ysZtnFe0Nxvox-g6mZ-M02jLA9aOc/edit?pli=1
Attachments
Patch
(225.36 KB, patch)
2013-08-22 07:32 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(225.62 KB, patch)
2013-08-22 08:13 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2013-07-31 23:07:44 PDT
Corresponding Blink revision:
https://src.chromium.org/viewvc/blink?revision=155264&view=revision
Chris Dumez
Comment 2
2013-08-05 00:11:38 PDT
Follow up Blink patches:
https://src.chromium.org/viewvc/blink?revision=155426&view=revision
https://src.chromium.org/viewvc/blink?revision=155469&view=revision
Chris Dumez
Comment 3
2013-08-22 07:32:24 PDT
Created
attachment 209365
[details]
Patch
Build Bot
Comment 4
2013-08-22 08:03:02 PDT
Comment on
attachment 209365
[details]
Patch
Attachment 209365
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/1538110
Chris Dumez
Comment 5
2013-08-22 08:13:56 PDT
Created
attachment 209369
[details]
Patch
Andreas Kling
Comment 6
2013-08-22 08:50:16 PDT
Comment on
attachment 209369
[details]
Patch r=me
Chris Dumez
Comment 7
2013-08-22 10:06:41 PDT
I will wait a bit to land in case an SVG specialist wants to take a look as well. However, I do not wish to wait too long as the patch is huge and would be a pain to rebase. Please let me know.
Philip Rogers
Comment 8
2013-08-22 14:30:15 PDT
This also looks good to me. R+!
WebKit Commit Bot
Comment 9
2013-08-22 14:57:07 PDT
Comment on
attachment 209369
[details]
Patch Clearing flags on attachment: 209369 Committed
r154462
: <
http://trac.webkit.org/changeset/154462
>
WebKit Commit Bot
Comment 10
2013-08-22 14:57:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug