WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
107175
[Chromium] Incorrect |isRedirect| value passed to decidePolicyForNavigation
https://bugs.webkit.org/show_bug.cgi?id=107175
Summary
[Chromium] Incorrect |isRedirect| value passed to decidePolicyForNavigation
Marshall Greenblatt
Reported
2013-01-17 13:51:45 PST
Chromium revision 176706 WebKit revision 139548 1. Load an application that uses the Chromium WebKit API. 2. Redirect a request via net::URLRequestJob::IsRedirectResponse by populating |location| and returning true. The |isRedirect| value passed to WebFrameClient::decidePolicyForNavigation in FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction should be true. However, WebKit revision 137607 (
http://trac.webkit.org/changeset/137607
) changed the implementation of MainResourceLoader::load() such that WebDataSourceImpl::appendRedirect() is no longer called for the redirected URL following this code path. As a result the |isRedirect| value is now false.
Attachments
Add attachment
proposed patch, testcase, etc.
Nate Chapin
Comment 1
2013-01-17 13:56:16 PST
(In reply to
comment #0
)
> Chromium revision 176706 > WebKit revision 139548 > > 1. Load an application that uses the Chromium WebKit API. > 2. Redirect a request via net::URLRequestJob::IsRedirectResponse by populating |location| and returning true. > > The |isRedirect| value passed to WebFrameClient::decidePolicyForNavigation in FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction should be true. However, WebKit revision 137607 (
http://trac.webkit.org/changeset/137607
) changed the implementation of MainResourceLoader::load() such that WebDataSourceImpl::appendRedirect() is no longer called for the redirected URL following this code path. As a result the |isRedirect| value is now false.
At a quick glance, this is probably because the timing of the call to dispatchDidReceiveServerRedirectForProvisionalLoad() changed.
Marshall Greenblatt
Comment 2
2013-04-08 16:03:04 PDT
Moved to Blink as
https://code.google.com/p/chromium/issues/detail?id=229154
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug