RESOLVED FIXED 106597
We should be able to checkpoint and restore the HTMLTokenizer across threads 
https://bugs.webkit.org/show_bug.cgi?id=106597
Summary We should be able to checkpoint and restore the HTMLTokenizer across threads
Adam Barth
Reported 2013-01-10 13:48:42 PST
We should be able to checkpoint and restore the HTMLTokenizer across threads
Attachments
Experiment---will need later (4.82 KB, patch)
2013-01-10 13:49 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Experiment---will need later (4.86 KB, patch)
2013-01-10 13:57 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (8.99 KB, patch)
2013-01-10 17:41 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch (6.92 KB, patch)
2013-01-11 10:31 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch (6.93 KB, patch)
2013-01-11 10:44 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-01-10 13:49:36 PST
Created attachment 182199 [details] Experiment---will need later
Adam Barth
Comment 2 2013-01-10 13:57:01 PST
Created attachment 182200 [details] Experiment---will need later
Tony Gentilcore
Comment 3 2013-01-10 17:41:13 PST
Created attachment 182231 [details] Patch
Adam Barth
Comment 4 2013-01-10 17:48:56 PST
Comment on attachment 182231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182231&action=review > Source/WebCore/html/parser/HTMLTokenizer.cpp:143 > + if (!m_appropriateEndTagName.isEmpty()) // Asserts because m_appropriateEndTagName is never cleared anywhere. We probably just need to clear it. We originally were very cheap about not clearing buffers in the tokenizer.
Tony Gentilcore
Comment 5 2013-01-11 10:31:49 PST
Created attachment 182364 [details] Patch
Build Bot
Comment 6 2013-01-11 10:38:05 PST
Comment on attachment 182364 [details] Patch Attachment 182364 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15804436
Tony Gentilcore
Comment 7 2013-01-11 10:44:31 PST
Created attachment 182369 [details] Patch
Adam Barth
Comment 8 2013-01-11 10:54:23 PST
Comment on attachment 182369 [details] Patch LGTM. Perhaps we should have Eric review the patch since we collaborated on writing it?
Adam Barth
Comment 9 2013-01-11 14:16:33 PST
Comment on attachment 182369 [details] Patch Eric seems to be absorbed in threading code, so I'll review this patch.
WebKit Review Bot
Comment 10 2013-01-11 14:21:37 PST
Comment on attachment 182369 [details] Patch Clearing flags on attachment: 182369 Committed r139497: <http://trac.webkit.org/changeset/139497>
WebKit Review Bot
Comment 11 2013-01-11 14:21:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.