RESOLVED FIXED 104792
[GStreamer] Current GStreamer 1.0 build setup can happen without the appropriate plugins 
https://bugs.webkit.org/show_bug.cgi?id=104792
Summary [GStreamer] Current GStreamer 1.0 build setup can happen without the appropri...
Xabier Rodríguez Calvar
Reported 2012-12-12 03:48:54 PST
When landing patch for bug 91727 we had some trouble in the bots because there were some missing libraries in the bots systems so the corresponding GStreamer plugins were not built. Those plugins are needed to run the tests, but no special versions of the libraries are needed. At least that we know the libraries that we needed to install were: libtheora-dev libvorbis-dev libfaad-dev I should check it we need some more anyway. We have three choices now: 1. Trusting what the wiki says and telling people to RTFM when they have a lot of timing out tests 2. Force GStreamer to build those plugins so it will complain when it cannot find the missing libraries. 3. Add the libraries to the internal jhbuild environment so that we ensure that they are built. IMHO, we should go for 2 because those are dependencies of GStreamer plugins, not WebKit itself and we avoid bloating even more the internal jhbuild, but at the same time, we are forcing people to fight against a compilation error that is easier to find than a runtime one. Phil thinks we should go for 3 because they those libraries are needed to run the tests eventually so they should be there. Opinions?
Attachments
Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-12-12 04:09:37 PST
There's no need to set a bug dependency on a closed bug, mentionning the other bug in this one is enough.
Philippe Normand
Comment 2 2012-12-12 04:11:05 PST
I don't think we'd be "bloating" the moduleset more by adding 3 modules that clearly affect the media tests ;)
Gustavo Noronha (kov)
Comment 3 2012-12-23 06:00:06 PST
We already rely on having a bunch of packages installed for features we need, so I think it's OK to just add these to the list and add a note explaining tests will timeout if they are not installed when the jhbuild stuff is built.
Chris Dumez
Comment 4 2013-01-09 03:27:42 PST
Based on my testing, it seems libpulse-dev is also needed for gst-plugins-good. Without it, the pulseaudio support was not built and the following command would fail on my machine: GRefPtr<GstElement> audioSink = gst_element_factory_make("autoaudiosink", 0); GstStateChangeReturn stateChangeReturn = gst_element_set_state(audioSink.get(), GST_STATE_READY); // Could return GST_STATE_CHANGE_FAILURE BTW, libpulse-dev is not mentioned on the BuildWebKitGTK wiki page.
Xabier Rodríguez Calvar
Comment 5 2013-01-09 09:29:20 PST
(In reply to comment #4) > BTW, libpulse-dev is not mentioned on the BuildWebKitGTK wiki page. Yes, I just added it and updated the bots accordingly. After talking to Phil we agreed on going with the option 1, which is just updating the wiki, so we can consider this bug as closed.
Note You need to log in before you can comment on or make changes to this bug.