RESOLVED FIXED 104629
[EFL][WK2] MiniBrowser is not built 
https://bugs.webkit.org/show_bug.cgi?id=104629
Summary [EFL][WK2] MiniBrowser is not built
Jinwoo Song
Reported 2012-12-10 21:46:40 PST
Currently, MiniBrowser is not built therefore the binary is not generated. As we are finding elementary package in Tools/MiniBrowser/efl/CMakeList.txt since r137203, we need to check the package finding in the same place not in the Tools/CMakeList.txt.
Attachments
Patch (2.16 KB, patch)
2012-12-10 21:48 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2012-12-10 21:48:56 PST
Created attachment 178708 [details] Patch
Gyuyoung Kim
Comment 2 2012-12-11 02:59:02 PST
Comment on attachment 178708 [details] Patch I think this is side effect by r137203. I think we need to build WebKit EFL on Tizen as well. So, LGTM.
Gyuyoung Kim
Comment 3 2012-12-11 03:11:54 PST
Comment on attachment 178708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178708&action=review > Tools/MiniBrowser/efl/CMakeLists.txt:54 > +if (ELEMENTARY_FOUND) BTW, is this guard needed ? If elementary can't be found, main.c in MiniBrowser won't be compiled.
WebKit Review Bot
Comment 4 2012-12-11 03:11:55 PST
Comment on attachment 178708 [details] Patch Clearing flags on attachment: 178708 Committed r137279: <http://trac.webkit.org/changeset/137279>
WebKit Review Bot
Comment 5 2012-12-11 03:11:59 PST
All reviewed patches have been landed. Closing bug.
Jinwoo Song
Comment 6 2012-12-11 03:23:13 PST
(In reply to comment #3) > (From update of attachment 178708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178708&action=review > > > Tools/MiniBrowser/efl/CMakeLists.txt:54 > > +if (ELEMENTARY_FOUND) > > BTW, is this guard needed ? If elementary can't be found, main.c in MiniBrowser won't be compiled. I added that guard to prevent the build error although the elementary package is not found.
Laszlo Gombos
Comment 7 2012-12-11 05:29:51 PST
Thanks for the follow-up fix, it looks good to me !
Note You need to log in before you can comment on or make changes to this bug.