RESOLVED FIXED 104457
Remove code duplicates from MacroAssemblerARM 
https://bugs.webkit.org/show_bug.cgi?id=104457
Summary Remove code duplicates from MacroAssemblerARM
Patrick R. Gansterer
Reported 2012-12-08 14:22:45 PST
Remove code duplicates from MacroAssemblerARM
Attachments
Patch (4.28 KB, patch)
2012-12-08 14:30 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (4.32 KB, patch)
2013-02-01 14:56 PST, Patrick R. Gansterer 		webkit.review.bot: review-
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-12-08 14:30:34 PST
Created attachment 178381 [details] Patch
Darin Adler
Comment 2 2012-12-08 14:32:42 PST
Comment on attachment 178381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178381&action=review > Source/JavaScriptCore/assembler/MacroAssemblerARM.h:491 > - m_assembler.ldrUniqueImmediate(ARMRegisters::S0, reinterpret_cast<ARMWord>(address)); > - m_assembler.moveImm(imm.m_value, ARMRegisters::S1); > - m_assembler.dtrUp(ARMAssembler::StoreUint32, ARMRegisters::S1, ARMRegisters::S0, 0); > + move(imm, ARMRegisters::S1); > + store32(ARMRegisters::S1, address); This doesn’t generate the same code. The moveImm will now come first, before the ldrUniqueImmediate. Is that OK? Is one or the other faster?
Patrick R. Gansterer
Comment 3 2013-02-01 14:56:31 PST
Created attachment 186152 [details] Patch
Csaba Osztrogonác
Comment 4 2013-02-15 03:28:42 PST
Could you check this bug?
WebKit Review Bot
Comment 5 2013-02-15 10:58:29 PST
Comment on attachment 186152 [details] Patch Rejecting attachment 186152 [details] from review queue. oliver@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
WebKit Review Bot
Comment 6 2013-02-15 11:13:28 PST
Comment on attachment 186152 [details] Patch Rejecting attachment 186152 [details] from commit-queue. oliver@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Patrick R. Gansterer
Comment 7 2013-04-10 13:32:16 PDT
Committed r148134: <http://trac.webkit.org/changeset/148134>
Note You need to log in before you can comment on or make changes to this bug.