RESOLVED FIXED 104271
[EFL] [AC]Implement ImageExtractor::extractImage in GraphicsContext3DEfl 
https://bugs.webkit.org/show_bug.cgi?id=104271
Summary [EFL] [AC]Implement ImageExtractor::extractImage in GraphicsContext3DEfl
Kalyan
Reported 2012-12-06 09:49:57 PST
Each platform must provide an implementation of this method.
Attachments
patch (3.93 KB, patch)
2012-12-06 11:27 PST, Kalyan 		kenneth: review-
DetailsFormatted DiffDiff
review fixes (3.91 KB, patch)
2012-12-06 14:02 PST, Kalyan 		kenneth: review+
kenneth: commit-queue-
DetailsFormatted DiffDiff
review fixes (3.92 KB, patch)
2012-12-06 22:00 PST, Kalyan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kalyan
Comment 1 2012-12-06 11:27:48 PST
Created attachment 178042 [details] patch
Kenneth Rohde Christiansen
Comment 2 2012-12-06 12:34:40 PST
Comment on attachment 178042 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=178042&action=review > Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:248 > + if (m_decoder) > + delete m_decoder; no, just delete m_decoder! this si c++ > Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:253 > + // This implementation is taken from GraphicsContext3DCairo dot at end > Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:311 > + return true; > + > } one newline too much. Also add newline before return
Kalyan
Comment 3 2012-12-06 14:02:50 PST
Created attachment 178076 [details] review fixes
Kenneth Rohde Christiansen
Comment 4 2012-12-06 16:48:24 PST
Comment on attachment 178076 [details] review fixes View in context: https://bugs.webkit.org/attachment.cgi?id=178076&action=review > Source/WebCore/ChangeLog:10 > + Covered by exisiting tests. spelling
Kalyan
Comment 5 2012-12-06 22:00:06 PST
Created attachment 178159 [details] review fixes
WebKit Review Bot
Comment 6 2012-12-07 02:50:58 PST
Comment on attachment 178159 [details] review fixes Clearing flags on attachment: 178159 Committed r136942: <http://trac.webkit.org/changeset/136942>
WebKit Review Bot
Comment 7 2012-12-07 02:51:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.