WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103198
[Qt] QStyleFacadeImp build break with latest Qt 5
https://bugs.webkit.org/show_bug.cgi?id=103198
Summary
[Qt] QStyleFacadeImp build break with latest Qt 5
J-P Nurmi
Reported
2012-11-25 09:40:07 PST
QMacStyle has been made internal in Qt 5. The QMacStyle include should be removed, and relevant qobject_casts should be replaced by QObject::inherits("QMacStyle"). Change I44a2f5ee: Made QMacStyle internal
https://codereview.qt-project.org/#change,39716
Attachments
Patch
(3.92 KB, patch)
2012-11-26 01:57 PST
,
Michael Brüning
hausmann
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Brüning
Comment 1
2012-11-26 00:27:40 PST
Will make a fix.
Michael Brüning
Comment 2
2012-11-26 01:57:20 PST
Created
attachment 175944
[details]
Patch
Simon Hausmann
Comment 3
2012-11-26 02:28:55 PST
Comment on
attachment 175944
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=175944&action=review
> Source/WebKit/qt/ChangeLog:8 > + Original patch by J-P Nurmi <
jpnurmi@gmail.com
>.
Shouldn't that be his digia email address?
Michael Brüning
Comment 4
2012-11-26 02:36:20 PST
Committed
r135696
: <
http://trac.webkit.org/changeset/135696
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug