RESOLVED FIXED 101900
changing pseudoClass (:enabled) should cause distribution 
https://bugs.webkit.org/show_bug.cgi?id=101900
Summary changing pseudoClass (:enabled) should cause distribution
Shinya Kawanaka
Reported 2012-11-11 23:13:20 PST
When these pseudo classes are changed, we should invalidate distribution.
Attachments
Patch (28.87 KB, patch)
2012-11-15 18:17 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-15 18:17:08 PST
Created attachment 174582 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2012-11-15 19:03:54 PST
Comment on attachment 174582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174582&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:154 > + invalidateParentDistributionIfNecessary(this, SelectRuleFeatureSet::RuleFeatureDisabled | SelectRuleFeatureSet::RuleFeatureEnabled); Wait... how can it be both enabled and disabled?
Shinya Kawanaka
Comment 3 2012-11-15 19:30:45 PST
(In reply to comment #2) > (From update of attachment 174582 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174582&action=review > > > Source/WebCore/html/HTMLFormControlElement.cpp:154 > > + invalidateParentDistributionIfNecessary(this, SelectRuleFeatureSet::RuleFeatureDisabled | SelectRuleFeatureSet::RuleFeatureEnabled); > > Wait... how can it be both enabled and disabled? This is just a mask. When either :disabled or :enabled is collected, we invalidate distribution.
Shinya Kawanaka
Comment 4 2012-11-15 19:36:02 PST
Comment on attachment 174582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174582&action=review >>> Source/WebCore/html/HTMLFormControlElement.cpp:154 >>> + invalidateParentDistributionIfNecessary(this, SelectRuleFeatureSet::RuleFeatureDisabled | SelectRuleFeatureSet::RuleFeatureEnabled); >> >> Wait... how can it be both enabled and disabled? > > This is just a mask. When either :disabled or :enabled is collected, we invalidate distribution. So it cannot be both 'enabled' and 'disabled'.
WebKit Review Bot
Comment 5 2012-11-15 19:55:10 PST
Comment on attachment 174582 [details] Patch Clearing flags on attachment: 174582 Committed r134883: <http://trac.webkit.org/changeset/134883>
WebKit Review Bot
Comment 6 2012-11-15 19:55:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.