RESOLVED CONFIGURATION CHANGED 101316
ShadowRoot::insertedInto is called many times without calling removedFrom when parsing <video controls> 
https://bugs.webkit.org/show_bug.cgi?id=101316
Summary ShadowRoot::insertedInto is called many times without calling removedFrom whe...
Shinya Kawanaka
Reported 2012-11-06 00:28:15 PST
I noticed this when I was working for Bug 100922. This might cause mysterious errors in future.
Attachments
Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-06 20:26:44 PST
The root cause seems HTMLMediaElement creates Shadow subtree in insertedInto(). This seems a bad signal...
Hajime Morrita
Comment 2 2012-11-08 22:31:55 PST
(In reply to comment #1) > The root cause seems HTMLMediaElement creates Shadow subtree in insertedInto(). > This seems a bad signal... It sounds reasonable to get rid of the shadow construction from insertedInto(). I'm not sure where is the best place though. It needs further investigation.
Dimitri Glazkov (Google)
Comment 3 2012-11-09 09:18:23 PST
Yeah, this is crufty. insertedInto is a really low-level hook, and it's tempting to use it various convenient purposes. However, being a low-level hook, it's also a minefield in situations like this.
Ryosuke Niwa
Comment 4 2019-10-04 22:48:34 PDT
configureMediaControls() is now called in HTMLMediaElement::didFinishInsertingNode() so this is no longer happening.
Note You need to log in before you can comment on or make changes to this bug.