WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100907
Coordinated Graphics: Clean up headers of Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=100907
Summary
Coordinated Graphics: Clean up headers of Coordinated Graphics.
Dongseong Hwang
Reported
2012-10-31 17:57:27 PDT
This patch performs: 1. Remove unused method declarations. 2. Change public methods to private if needed. 3. Put virtual, OVERRIDE and explicit keywords if needed.
Attachments
Patch
(16.70 KB, patch)
2012-10-31 17:59 PDT
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
Patch
(16.67 KB, patch)
2012-10-31 23:34 PDT
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dongseong Hwang
Comment 1
2012-10-31 17:59:47 PDT
Created
attachment 171748
[details]
Patch
Dongseong Hwang
Comment 2
2012-10-31 23:34:26 PDT
Created
attachment 171778
[details]
Patch
WebKit Review Bot
Comment 3
2012-11-01 08:56:15 PDT
Comment on
attachment 171778
[details]
Patch Clearing flags on attachment: 171778 Committed
r133182
: <
http://trac.webkit.org/changeset/133182
>
WebKit Review Bot
Comment 4
2012-11-01 08:56:19 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5
2012-11-01 13:59:43 PDT
It broks the Qt Mac build, please fix it as soon as possible... and watch the bots next time.
Csaba Osztrogonác
Comment 6
2012-11-01 14:02:44 PDT
and the Qt win build too
Nandor Huszka
Comment 7
2012-11-01 15:25:04 PDT
I've created a bug for the build fix:
https://bugs.webkit.org/show_bug.cgi?id=100995
Dongseong Hwang
Comment 8
2012-11-01 16:24:41 PDT
(In reply to
comment #6
)
> and the Qt win build too
(In reply to
comment #7
)
> I've created a bug for the build fix:
https://bugs.webkit.org/show_bug.cgi?id=100995
Sorry to bothering you. Thank for reporting and bug fix.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug