RESOLVED FIXED 100599
DFG::Array::Mode needs to be cleaned up 
https://bugs.webkit.org/show_bug.cgi?id=100599
Summary DFG::Array::Mode needs to be cleaned up
Filip Pizlo
Reported 2012-10-27 20:53:52 PDT
It's really a tuple of the type, the level of speculation you're doing (in-bounds, hole, out-of-bounds), whether or not there's a conversion, and whether or not we're dealing with a JSArray.
Attachments
almost done (98.67 KB, patch)
2012-10-27 20:58 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (110.53 KB, patch)
2012-10-27 21:17 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (110.47 KB, patch)
2012-10-27 21:35 PDT, Filip Pizlo 		oliver: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (113.76 KB, patch)
2012-10-27 22:05 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-10-27 20:58:15 PDT
Created attachment 171116 [details] almost done
Filip Pizlo
Comment 2 2012-10-27 21:17:07 PDT
Created attachment 171118 [details] the patch
Filip Pizlo
Comment 3 2012-10-27 21:35:54 PDT
Created attachment 171119 [details] the patch Did some rebasing.
Build Bot
Comment 4 2012-10-27 21:40:37 PDT
Comment on attachment 171119 [details] the patch Attachment 171119 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14605829
WebKit Review Bot
Comment 5 2012-10-27 21:40:53 PDT
Attachment 171119 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:2418: The parameter name "arrayMode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 6 2012-10-27 21:42:58 PDT
Comment on attachment 171119 [details] the patch Attachment 171119 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14614698
Early Warning System Bot
Comment 7 2012-10-27 21:43:06 PDT
Comment on attachment 171119 [details] the patch Attachment 171119 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14607699
Filip Pizlo
Comment 8 2012-10-27 21:45:19 PDT
(In reply to comment #4) > (From update of attachment 171119 [details]) > Attachment 171119 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/14605829 These build failures are easy to fix.
Filip Pizlo
Comment 9 2012-10-27 21:45:31 PDT
(In reply to comment #5) > Attachment 171119 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:2418: The parameter name "arrayMode" adds no information, so it should be removed. [readability/parameter_name] [5] > Total errors found: 1 in 16 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I will fix.
Filip Pizlo
Comment 10 2012-10-27 22:05:52 PDT
Created attachment 171120 [details] patch for landing
Filip Pizlo
Comment 11 2012-10-27 23:14:08 PDT
Landed in http://trac.webkit.org/changeset/132745
Note You need to log in before you can comment on or make changes to this bug.