RESOLVED FIXED 100230
[EFL][WK2] Get rid of Ewk_View private C API (Part 1) 
https://bugs.webkit.org/show_bug.cgi?id=100230
Summary [EFL][WK2] Get rid of Ewk_View private C API (Part 1)
Chris Dumez
Reported 2012-10-24 04:38:37 PDT
As part of the Ewk_View refactoring (Bug 100226), we are planning to get rid of the Ewk_View private C API. This private C API will be replaced by C++ methods in the new EwkViewImpl class (Bug 99696).
Attachments
Patch (151.34 KB, patch)
2012-10-24 11:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (150.55 KB, patch)
2012-10-24 12:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-24 04:39:27 PDT
(In reply to comment #0) > As part of the Ewk_View refactoring (Bug 100226), we are planning to get rid of the Ewk_View private C API. > > This private C API will be replaced by C++ methods in the new EwkViewImpl class (Bug 99696). The new EwkViewImpl class is Bug 100228, not 99696. Sorry.
Chris Dumez
Comment 2 2012-10-24 10:51:00 PDT
I will do this in 2 parts (at least) because it gets too big otherwise and it would become a rebasing nightmare.
Chris Dumez
Comment 3 2012-10-24 11:25:11 PDT
Created attachment 170436 [details] Patch
Kenneth Rohde Christiansen
Comment 4 2012-10-24 12:25:11 PDT
Comment on attachment 170436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170436&action=review > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:39 > +#define EWK_VIEW_IMPL_GET(smartData, viewImpl) \ > + EwkViewImpl* viewImpl = smartData->priv why not just call it impl? > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:127 > + void reportDownloadJobCancelled(Ewk_Download_Job* download); > + void reportDownloadJobFailed(Ewk_Download_Job* download, Ewk_Error* error); > + void reportDownloadJobFinished(Ewk_Download_Job* download); > + void reportDownloadJobRequested(Ewk_Download_Job* download); > + I dont like report :-) why not inform ? :) report sounds like logging to me
Chris Dumez
Comment 5 2012-10-24 12:47:40 PDT
Created attachment 170452 [details] Patch Take Kenneth's feedback into consideration.
WebKit Review Bot
Comment 6 2012-10-24 14:52:10 PDT
Comment on attachment 170452 [details] Patch Clearing flags on attachment: 170452 Committed r132405: <http://trac.webkit.org/changeset/132405>
WebKit Review Bot
Comment 7 2012-10-24 14:52:14 PDT
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 8 2012-10-25 07:00:26 PDT
(In reply to comment #4) > (From update of attachment 170436 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170436&action=review > > > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:39 > > +#define EWK_VIEW_IMPL_GET(smartData, viewImpl) \ > > + EwkViewImpl* viewImpl = smartData->priv > > why not just call it impl? > > > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:127 > > + void reportDownloadJobCancelled(Ewk_Download_Job* download); > > + void reportDownloadJobFailed(Ewk_Download_Job* download, Ewk_Error* error); > > + void reportDownloadJobFinished(Ewk_Download_Job* download); > > + void reportDownloadJobRequested(Ewk_Download_Job* download); > > + > > I dont like report :-) why not inform ? :) report sounds like logging to me Notify?
Note You need to log in before you can comment on or make changes to this bug.