Bug 91740
| Summary: | WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED should be defined in Platform.h instead of wtf/Atomics.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Wei James (wistoch) <james.wei> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap, mjs, peter |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Wei James (wistoch)
WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED is defined in wtf/Atomic.h, which should be in Platform.h
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Can you please provide the rationale? We have most USE macros defined in Platform.h indeed, but it's not great to dump them all together in one file. So, I'm honestly unsure if this would be an improvement.
Wei James (wistoch)
(In reply to comment #1)
> Can you please provide the rationale? We have most USE macros defined in Platform.h indeed, but it's not great to dump them all together in one file. So, I'm honestly unsure if this would be an improvement.
see https://bugs.webkit.org/show_bug.cgi?id=89428#c16
there may be some misunderstanding in the bug #89428, peter asked me to put a MACRO in platform.h instead of Atomic.h. I misunderstood him and thought we shoudl put all MACRO in platform.h instead of Atomics.h.
please ignore this bug entry. thanks