Bug 91717

Summary: DFG cell checks should be hoisted
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, mhahnenberg, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 92002    
Bug Blocks:    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2012-07-18 23:38:19 PDT
Patch forthcoming.
Attachments
the patch (13.62 KB, patch)
2012-07-18 23:47 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-07-18 23:47:30 PDT
Created attachment 153189 [details] the patch
WebKit Review Bot
Comment 2 2012-07-18 23:51:04 PDT
Attachment 153189 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:1000: testq_rm is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2012-07-19 10:51:44 PDT
Comment on attachment 153189 [details] the patch r=me
Filip Pizlo
Comment 4 2012-07-19 20:52:52 PDT
Landed in http://trac.webkit.org/changeset/123169
Note You need to log in before you can comment on or make changes to this bug.