Bug 91490
| Summary: | [Qt][WK2] REGRESSION(r122770) - it made ~ 160 fails on WebKit2 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | János Badics <jbadics> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | allan.jensen, eric, hausmann, hyatt, jturcotte, kadam, kbalazs, kkristof, ossy, simon.fraser, szledan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 79666, 91425 | ||
János Badics
156 tests fail on WebKit2 since r122768 or r122771.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Balazs Kelemen
(In reply to comment #0)
> 156 tests fail on WebKit2 since r122768 or r122771.
... or any change in between the two.
Balazs Kelemen
This is definitely not a jsc issue.
Allan Sandfeld Jensen
r122769 is a rounding change (from floored int to rounded int for us), that could likely change metrics slightly all over the place.
Balazs Kelemen
(In reply to comment #3)
> r122769 is a rounding change (from floored int to rounded int for us), that could likely change metrics slightly all over the place.
I rather suspect on r122770, I'm going to check these changes invidually (on 67).
Balazs Kelemen
This is caused by r122770 (bisected).
Balazs Kelemen
Link of results: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20(Amazon%20EC2)/r122771%20(6073)/results.html (it refers to 71 because 67-70 did not build).
Eric Seidel (no email)
http://trac.webkit.org/changeset/122770
Eric Seidel (no email)
Links make it easy to see what the change in question was. Also relating to the original bug may help get the attention of the authors of the original change, if that's your goal.
Simon Fraser (smfr)
I find it hard to believe that r122770 caused those changes.
Balazs Kelemen
(In reply to comment #8)
> Links make it easy to see what the change in question was. Also relating to the original bug may help get the attention of the authors of the original change, if that's your goal.
Not for making a flame war of it but what is the rationale of blocking a resolved bug? I commented on that bug, I believe it should be enough to get the attention of the authors. Links are good idea, though :)
Csaba Osztrogonác
*** This bug has been marked as a duplicate of bug 88064 ***