Bug 90287

Summary: [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, gyuyoung.kim, kbalazs, kpiascik, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-06-29 08:43:09 PDT
fast/viewport/viewport-91.html is failing after r121555 and should be skipped until bug 90286 is fixed.
Attachments
Patch (2.46 KB, patch)
2012-06-29 08:57 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (4.18 KB, patch)
2012-07-01 06:09 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-06-29 08:57:18 PDT
Created attachment 150192 [details] Patch
WebKit Review Bot
Comment 2 2012-06-29 11:52:38 PDT
Comment on attachment 150192 [details] Patch Clearing flags on attachment: 150192 Committed r121579: <http://trac.webkit.org/changeset/121579>
WebKit Review Bot
Comment 3 2012-06-29 11:52:43 PDT
All reviewed patches have been landed. Closing bug.
Balazs Kelemen
Comment 4 2012-07-01 03:46:50 PDT
Doesn't it mean that the patch is bad? If so, why don't we revert instead? Or maybe we just need to change some call sites in wk2 platform code?
Balazs Kelemen
Comment 5 2012-07-01 05:43:18 PDT
Here is the diff on Qt: -viewport size 320x356 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000 +viewport size 480x534 scale 1.000000 with limits [1.000000, 5.000000] and userScalable -1.000000 Relevant parts of the test: <meta name="viewport" content="width=device-width"> layoutTestController.dumpConfigurationForViewport(240, 480, 564, 480, 534); So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites.
Balazs Kelemen
Comment 6 2012-07-01 06:09:41 PDT
Reopening to attach new patch.
Balazs Kelemen
Comment 7 2012-07-01 06:09:50 PDT
Created attachment 150329 [details] Patch
Balazs Kelemen
Comment 8 2012-07-01 06:11:38 PDT
> So we don't divide the width and height dimensions with 1.5 (240/160), which is surprising, since the patch keeps the division, just organize it to the call sites. ... but it turned it to an int division :)
Konrad Piascik
Comment 9 2012-07-01 06:23:28 PDT
I've already got a patch for this in https://bugs.webkit.org/show_bug.cgi?id=90286 But commit queue was being a little stupid so I'd need to re-submit. I don't have time to do this till Tuesday, so you can push this patch now and close the other bug or wait for me to update mine.
Build Bot
Comment 10 2012-07-01 06:34:50 PDT
Comment on attachment 150329 [details] Patch Attachment 150329 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13113854
Balazs Kelemen
Comment 11 2012-07-02 00:38:44 PDT
(In reply to comment #9) > I've already got a patch for this in https://bugs.webkit.org/show_bug.cgi?id=90286 But commit queue was being a little stupid so I'd need to re-submit. I don't have time to do this till Tuesday, so you can push this patch now and close the other bug or wait for me to update mine. Well, my patch did not build on Windows, so instead I lent your patch - http://trac.webkit.org/changeset/121661. *** This bug has been marked as a duplicate of bug 90286 ***
Note You need to log in before you can comment on or make changes to this bug.