Bug 89333
Summary: | [Qt] REGRESSION(r120311): It made inspector/extensions/extensions-panel.html flakey | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | Tools / Tests | Assignee: | Andrey Kosyakov <caseq> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | caseq, janx, jbadics, ossy, pfeldman |
Priority: | P2 | Keywords: | Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 90799 | ||
Bug Blocks: | 79666, 88473 |
Csaba Osztrogonác
http://trac.webkit.org/changeset/120311 made inspector/extensions/extensions-panel.html
flakey at least on Qt platform. It fails intermittently with the following diff:
--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-expected.txt
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-actual.txt
@@ -21,8 +21,8 @@
createStatusBarButton : <function>
show : <function>
}
+Panel shown
Extension panel size correct
-Panel shown
RUNNING TEST: extension_testStatusBarButtons
Created a status bar button, dump follows:
{
Could you check it, please?
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
You can easily reproduce the bug:
$ Tools/Scripts/old-run-webkit-tests inspector/extensions/extensions-panel.html --iterations 100 --singly
54 test cases (54%) succeeded
46 test cases (46%) had incorrect layout
János Badics
I skipped this test on Qt until it is fixed. See
http://trac.webkit.org/changeset/120590
Csaba Osztrogonác
(In reply to comment #2)
> I skipped this test on Qt until it is fixed. See
> http://trac.webkit.org/changeset/120590
Great ... after skipping this test, inspector/extensions/extensions-reload.html started to fail constantly ...
Have you got any idea?
--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-reload-expected.txt
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-reload-actual.txt
@@ -1,11 +1,8 @@
+FAIL: Timed out waiting for notifyDone to be called
Tests that webInspector.inspectedWindow.reload() successfully injects user's code upon reload
Started extension.
+Page reloaded.
Running tests...
RUNNING TEST: extension_testReloadInjectsCode
-Page reloaded.
-Page reloaded.
-With injected code: foo = 42
-Without injected code: foo = undefined
-All tests done.
Csaba Osztrogonác
(In reply to comment #3)
> (In reply to comment #2)
> > I skipped this test on Qt until it is fixed. See
> > http://trac.webkit.org/changeset/120590
>
> Great ... after skipping this test, inspector/extensions/extensions-reload.html started to fail constantly ...
>
> Have you got any idea?
>
> --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-reload-expected.txt
> +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-reload-actual.txt
> @@ -1,11 +1,8 @@
> +FAIL: Timed out waiting for notifyDone to be called
> Tests that webInspector.inspectedWindow.reload() successfully injects user's code upon reload
>
> Started extension.
> +Page reloaded.
> Running tests...
> RUNNING TEST: extension_testReloadInjectsCode
> -Page reloaded.
> -Page reloaded.
> -With injected code: foo = 42
> -Without injected code: foo = undefined
> -All tests done.
I filed a new bug report on this new bug: https://bugs.webkit.org/show_bug.cgi?id=89349
Andrey Kosyakov
Should be fixed by r122216: http://trac.webkit.org/changeset/122216