Bug 88942

Summary: nrwt: preliminary cleanup before supporting cascading expectations files
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65834, 88944, 88945    
Attachments:
Description Flags
Patch ojan: review+

Dirk Pranke
Reported 2012-06-12 19:00:15 PDT
nrwt: preliminary cleanup before supporting cascading expectations files
Attachments
Patch (19.43 KB, patch)
2012-06-12 19:01 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-12 19:01:48 PDT
Created attachment 147212 [details] Patch
Ojan Vafai
Comment 2 2012-06-13 09:26:40 PDT
Comment on attachment 147212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147212&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:239 > + expectation_line.filename = '<Skipped file>' Should this have a FIXME to associate paths with Skipped file lines as well? I doubt we'll ever get around to it as we'll hopefully drop Skipped files entirely.
Dirk Pranke
Comment 3 2012-06-13 10:21:06 PDT
(In reply to comment #2) > (From update of attachment 147212 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147212&action=review > > > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:239 > > + expectation_line.filename = '<Skipped file>' > > Should this have a FIXME to associate paths with Skipped file lines as well? I doubt we'll ever get around to it as we'll hopefully drop Skipped files entirely. Two observations: the first is that some skipped entries are actually runtime-computed and don't actually live in files (some come from the command line as well). The second is that I'm planning to move the Skipped files to TestExpectations files (unless someone objects) and then, as you say, it'll go away. I'll add a comment, though.
Dirk Pranke
Comment 4 2012-06-13 11:50:19 PDT
Committed r120230: <http://trac.webkit.org/changeset/120230>
Dirk Pranke
Comment 5 2012-06-13 11:51:14 PDT
whoops, forgot the fixme ... will add it in the next patch.
Note You need to log in before you can comment on or make changes to this bug.