Bug 85621

Summary: Web Inspector: use single method for retrieving evaluation context in the runtime agent
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 85612    
Attachments:
Description Flags
Patch pfeldman: review+

Yury Semikhatsky
Reported 2012-05-04 07:29:48 PDT
It is a small refactoring that makes things a bit simpler.
Attachments
Patch (6.74 KB, patch)
2012-05-04 07:31 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-05-04 07:31:34 PDT
Created attachment 140220 [details] Patch
Pavel Feldman
Comment 2 2012-05-04 07:32:51 PDT
Comment on attachment 140220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140220&action=review > Source/WebCore/inspector/PageRuntimeAgent.cpp:55 > +ScriptState* PageRuntimeAgent::getScriptStateForEval(ErrorString* errorString, const String* frameId) we don't use get prefixes in WebKit.
Yury Semikhatsky
Comment 3 2012-05-04 07:34:13 PDT
(In reply to comment #2) > (From update of attachment 140220 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140220&action=review > > > Source/WebCore/inspector/PageRuntimeAgent.cpp:55 > > +ScriptState* PageRuntimeAgent::getScriptStateForEval(ErrorString* errorString, const String* frameId) > > we don't use get prefixes in WebKit. Fixed.
Yury Semikhatsky
Comment 4 2012-05-04 07:36:04 PDT
Committed r116099: <http://trac.webkit.org/changeset/116099>
Note You need to log in before you can comment on or make changes to this bug.