Bug 84680

Summary: Calendar Picker: Open a calendar picker by keyboard operation
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, haraken, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84192    
Attachments:
Description Flags
Patch
haraken: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03 none

Kent Tamura
Reported 2012-04-24 01:22:09 PDT
Calendar Picker: Open a calendar picker by keyboard operation
Attachments
Patch (6.22 KB, patch)
2012-04-24 01:31 PDT, Kent Tamura 		haraken: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-03 (6.03 MB, application/zip)
2012-04-24 11:39 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-04-24 01:31:54 PDT
Created attachment 138516 [details] Patch
Kentaro Hara
Comment 2 2012-04-24 04:22:50 PDT
Comment on attachment 138516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138516&action=review > Source/WebCore/ChangeLog:12 > + No new tests. This behavior is not testable by DRT yet. Just an out-of-curiosity question: What makes it difficult to test calendar picker behavior in DRT? > Source/WebCore/html/BaseDateAndTimeInputType.cpp:144 > + if (shouldHaveSpinButton()) > + handleWheelEventForSpinButton(event); Is this needed to this patch?
Kent Tamura
Comment 3 2012-04-24 06:31:32 PDT
Comment on attachment 138516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138516&action=review >> Source/WebCore/ChangeLog:12 >> + No new tests. This behavior is not testable by DRT yet. > > Just an out-of-curiosity question: What makes it difficult to test calendar picker behavior in DRT? Chromium DRT can't see objects not drawn in FrameViews because it has only one off-screen buffer and the main FrameView is drawn on it. >> Source/WebCore/html/BaseDateAndTimeInputType.cpp:144 >> + handleWheelEventForSpinButton(event); > > Is this needed to this patch? This change is for consistency. No spin button, no event handling for spin button. I should have mentioned this behavior change in ChangeLog.
Kentaro Hara
Comment 4 2012-04-24 06:34:13 PDT
Comment on attachment 138516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138516&action=review >>> Source/WebCore/html/BaseDateAndTimeInputType.cpp:144 >>> + handleWheelEventForSpinButton(event); >> >> Is this needed to this patch? > > This change is for consistency. No spin button, no event handling for spin button. > > I should have mentioned this behavior change in ChangeLog. Thanks for the clarification. Let's describe it in ChangeLog.
WebKit Review Bot
Comment 5 2012-04-24 11:39:33 PDT
Comment on attachment 138516 [details] Patch Attachment 138516 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12518296 New failing tests: fast/forms/date/date-stepup-stepdown-from-renderer.html
WebKit Review Bot
Comment 6 2012-04-24 11:39:43 PDT
Created attachment 138612 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Kent Tamura
Comment 7 2012-04-24 18:14:51 PDT
(In reply to comment #4) > > I should have mentioned this behavior change in ChangeLog. > > Thanks for the clarification. Let's describe it in ChangeLog. I have updated ChangeLog and date-stepup-stepdown-from-renderer.html, and I'm landing the patch.
Kent Tamura
Comment 8 2012-04-24 18:17:16 PDT
Committed r115155: <http://trac.webkit.org/changeset/115155>
Note You need to log in before you can comment on or make changes to this bug.