Bug 78558

Summary: Implement start/stop_helper for ChromiumAndroidPort
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, jnd, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78524    
Attachments:
Description Flags
Patch
none
Patch dpranke: review+

Adam Barth
Reported 2012-02-13 17:46:20 PST
Implement start/stop_helper for ChromiumAndroidPort
Attachments
Patch (11.27 KB, patch)
2012-02-13 17:48 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (11.83 KB, patch)
2012-02-13 17:52 PST, Adam Barth 		dpranke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-02-13 17:48:33 PST
Created attachment 126874 [details] Patch
Adam Barth
Comment 2 2012-02-13 17:52:07 PST
Created attachment 126876 [details] Patch
Dirk Pranke
Comment 3 2012-02-13 17:56:24 PST
Comment on attachment 126876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126876&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:35 > +_log = logging.getLogger('webkitpy.layout_tests.port.chromium_android') Nit: you should use __file__ here.
Adam Barth
Comment 4 2012-02-13 18:09:05 PST
> Nit: you should use __file__ here. Gah! (grepping around, it looks like we use __name__)
Adam Barth
Comment 5 2012-02-13 18:10:27 PST
Committed r107653: <http://trac.webkit.org/changeset/107653>
Eric Seidel (no email)
Comment 6 2012-02-13 18:13:39 PST
Sorry, yeah __name__ is likely better than __file__. I too often get them confused.
Dirk Pranke
Comment 7 2012-02-13 19:09:11 PST
(In reply to comment #4) > > Nit: you should use __file__ here. > > Gah! (grepping around, it looks like we use __name__) Sorry! I meant __name__.
Note You need to log in before you can comment on or make changes to this bug.