Bug 60806

Summary: Switch controlClipRect to use IntPoint
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 61390    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch eric: review+

Levi Weintraub
Reported 2011-05-13 14:41:07 PDT
Ongoing removal of tx/ty.
Attachments
Patch (10.88 KB, patch)
2011-05-24 12:33 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (10.85 KB, patch)
2011-05-25 10:18 PDT, Levi Weintraub 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-05-24 12:16:55 PDT
*** Bug 61383 has been marked as a duplicate of this bug. ***
Levi Weintraub
Comment 2 2011-05-24 12:33:19 PDT
Created attachment 94665 [details] Patch
Levi Weintraub
Comment 3 2011-05-24 12:33:59 PDT
Comment on attachment 94665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94665&action=review > Source/WebCore/rendering/RenderListBox.cpp:694 > + clipRect.move(additionalOffset.x(), additionalOffset.y()); It's a bit strange, but perhaps we should consider a flavor of IntRect::move that takes a point?
Emil A Eklund
Comment 4 2011-05-24 12:51:30 PDT
> It's a bit strange, but perhaps we should consider a flavor of IntRect::move that takes a point? I would support that, there's a lot of code in both the painting and the hit testing code that uses coordinates interchangeably as points and offsets. Being able to move a rect by a point would make it much easier to clean up that code without having to do a lot of conversions.
Levi Weintraub
Comment 5 2011-05-24 13:14:12 PDT
Comment on attachment 94665 [details] Patch Cool. I'm going to hold back on this and make it dependent on such a change.
Levi Weintraub
Comment 6 2011-05-25 10:18:29 PDT
Created attachment 94802 [details] Patch
Eric Seidel (no email)
Comment 7 2011-05-26 15:03:17 PDT
Comment on attachment 94802 [details] Patch This whole size vs. point mess is super-confusing.
Levi Weintraub
Comment 8 2011-05-26 15:49:12 PDT
Committed r87443: <http://trac.webkit.org/changeset/87443>
Note You need to log in before you can comment on or make changes to this bug.